Skip to content

Commit 53a5206

Browse files
committed
test: check recommended model URIs
1 parent 123e524 commit 53a5206

File tree

3 files changed

+44
-13
lines changed

3 files changed

+44
-13
lines changed

src/cli/recommendedModels.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -227,10 +227,8 @@ export const recommendedModels: ModelRecommendation[] = [{
227227
fileOptions: [
228228
"hf:bartowski/gemma-2-9b-it-GGUF:Q6_K_L",
229229
"hf:bartowski/gemma-2-9b-it-GGUF:Q6_K",
230-
"hf:bartowski/gemma-2-9b-it-GGUF:Q5_K_L",
231230
"hf:bartowski/gemma-2-9b-it-GGUF:Q5_K_M",
232231
"hf:bartowski/gemma-2-9b-it-GGUF:Q5_K_S",
233-
"hf:bartowski/gemma-2-9b-it-GGUF:Q4_K_L",
234232
"hf:bartowski/gemma-2-9b-it-GGUF:Q4_K_M"
235233
]
236234
}, {
@@ -258,10 +256,8 @@ export const recommendedModels: ModelRecommendation[] = [{
258256
fileOptions: [
259257
"hf:bartowski/gemma-2-27b-it-GGUF:Q6_K_L",
260258
"hf:bartowski/gemma-2-27b-it-GGUF:Q6_K",
261-
"hf:bartowski/gemma-2-27b-it-GGUF:Q5_K_L",
262259
"hf:bartowski/gemma-2-27b-it-GGUF:Q5_K_M",
263260
"hf:bartowski/gemma-2-27b-it-GGUF:Q5_K_S",
264-
"hf:bartowski/gemma-2-27b-it-GGUF:Q4_K_L",
265261
"hf:bartowski/gemma-2-27b-it-GGUF:Q4_K_M"
266262
]
267263
}, {
Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
import {describe, expect, test} from "vitest";
2+
import {parseModelUri, resolveParsedModelUri} from "../../../src/utils/parseModelUri.js";
3+
import {recommendedModels} from "../../../src/cli/recommendedModels.js";
4+
5+
describe("cli", () => {
6+
describe("recommended models", () => {
7+
test("all URIs resolve correctly", async () => {
8+
const unresolvedUris = (
9+
await Promise.all(
10+
recommendedModels
11+
.flatMap((modelOption) => (
12+
modelOption.fileOptions.map(((uri) => [modelOption.name, uri]))
13+
))
14+
.map(async ([modelName, uri]) => {
15+
if (uri == null)
16+
return null;
17+
18+
try {
19+
await resolveParsedModelUri(parseModelUri(uri));
20+
return null;
21+
} catch (err) {
22+
return {
23+
modelName,
24+
uri
25+
};
26+
}
27+
})
28+
)
29+
)
30+
.filter((unresolvedUri) => unresolvedUri != null);
31+
32+
expect(unresolvedUris).to.eql([]);
33+
});
34+
});
35+
});

test/standalone/utils/parseModelUri.test.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -230,38 +230,38 @@ describe("utils", () => {
230230
});
231231

232232
test("Hugging Face simple URI is resolved 2", async () => {
233-
const parsedModelUri = parseModelUri("hf:bartowski/Meta-Llama-3.1-70B-Instruct-GGUF:Q5_K_L");
233+
const parsedModelUri = parseModelUri("hf:bartowski/Meta-Llama-3.1-70B-Instruct-GGUF:Q5_K_M");
234234

235235
expect(parsedModelUri).toMatchInlineSnapshot(`
236236
{
237237
"baseFilename": "Meta-Llama-3.1-70B-Instruct",
238238
"filePrefix": "hf_bartowski_",
239239
"possibleFullFilenames": [
240-
"hf_bartowski_Meta-Llama-3.1-70B-Instruct.Q5_K_L.gguf",
241-
"hf_bartowski_Meta-Llama-3.1-70B-Instruct.Q5_K_L-00001-of-{:
240+
"hf_bartowski_Meta-Llama-3.1-70B-Instruct.Q5_K_M.gguf",
241+
"hf_bartowski_Meta-Llama-3.1-70B-Instruct.Q5_K_M-00001-of-{:
242242
{number}
243243
:}.gguf",
244244
],
245245
"resolveDetails": {
246246
"model": "Meta-Llama-3.1-70B-Instruct-GGUF",
247-
"tag": "Q5_K_L",
247+
"tag": "Q5_K_M",
248248
"type": "hf",
249249
"user": "bartowski",
250250
},
251251
"type": "unresolved",
252-
"uri": "hf:bartowski/Meta-Llama-3.1-70B-Instruct-GGUF:Q5_K_L",
252+
"uri": "hf:bartowski/Meta-Llama-3.1-70B-Instruct-GGUF:Q5_K_M",
253253
}
254254
`);
255255

256256
const resolvedUri = await resolveParsedModelUri(parsedModelUri);
257257
expect(resolvedUri).toMatchInlineSnapshot(`
258258
{
259259
"filePrefix": "hf_bartowski_",
260-
"filename": "Meta-Llama-3.1-70B-Instruct.Q5_K_L-00001-of-00002.gguf",
261-
"fullFilename": "hf_bartowski_Meta-Llama-3.1-70B-Instruct.Q5_K_L-00001-of-00002.gguf",
262-
"resolvedUrl": "https://huggingface.co/bartowski/Meta-Llama-3.1-70B-Instruct-GGUF/resolve/main/Meta-Llama-3.1-70B-Instruct-Q5_K_L/Meta-Llama-3.1-70B-Instruct-Q5_K_L-00001-of-00002.gguf?download=true",
260+
"filename": "Meta-Llama-3.1-70B-Instruct.Q5_K_M-00001-of-00002.gguf",
261+
"fullFilename": "hf_bartowski_Meta-Llama-3.1-70B-Instruct.Q5_K_M-00001-of-00002.gguf",
262+
"resolvedUrl": "https://huggingface.co/bartowski/Meta-Llama-3.1-70B-Instruct-GGUF/resolve/main/Meta-Llama-3.1-70B-Instruct-Q5_K_M/Meta-Llama-3.1-70B-Instruct-Q5_K_M-00001-of-00002.gguf?download=true",
263263
"type": "resolved",
264-
"uri": "hf:bartowski/Meta-Llama-3.1-70B-Instruct-GGUF:Q5_K_L",
264+
"uri": "hf:bartowski/Meta-Llama-3.1-70B-Instruct-GGUF:Q5_K_M",
265265
}
266266
`);
267267
});

0 commit comments

Comments
 (0)