fix: Allow importing when using a SEA binary #466
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testBindingBinary would throw when using a node-llama-cpp in a SEA binary. Add an exclusion to getShouldTestBinaryBeforeLoading to check for this and skip the test.
Description of change
As requested bringing this into the main repo as PR. Not sure if this is the right way to address this, but it fixed it when we were trying to bundle node-llama-cpp into a SEA binary.
Pull-Request Checklist
masterbranchnpm run formatto apply eslint formattingnpm run testpasses with this changeFixes #0000N/A