fix: correct URL handling for document and media input#251
Merged
Kamilbenkirane merged 1 commit intomainfrom Mar 28, 2026
Merged
fix: correct URL handling for document and media input#251Kamilbenkirane merged 1 commit intomainfrom
Kamilbenkirane merged 1 commit intomainfrom
Conversation
OpenResponses: use file_url field for URL-based documents instead of file_data (which expects base64 data URIs only). Google: include mime_type in file_data when using URL-based artifacts, fixing "Unsupported MIME type" errors for all media types. Also replaces empty test PDF with one containing actual text content.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file_urlfield for URL-based documents instead offile_data(which only accepts base64 data URIs)mime_typeinfile_datawhen using URL-based artifacts, fixingUnsupported MIME typeerrors for all media types (images, video, audio, documents)Root cause
Two bugs discovered during integration testing of #249:
file_data— API expectsdata:mime;base64,...format theredoc.url: usefile_urlfor URLs,file_datafor base64build_media_part()omittedmime_typefromfile_dataon URL pathartifact.mime_type.valuewhen availableTest plan