closes #4: sendPhoto() keyboard doesn't need to be deserialized and re-serialized

gerasdf · gerasdf · commit df4961da6d33 · 2020-05-25T17:26:51.000-03:00
diff --git a/src/UniversalTelegramBot.cpp b/src/UniversalTelegramBot.cpp
@@ -741,9 +741,7 @@ String UniversalTelegramBot::sendPhoto(String chat_id, String photo,
 
   if (!keyboard.isEmpty()) {
     JsonObject replyMarkup = payload.createNestedObject("reply_markup");
-    DynamicJsonDocument keyboardBuffer(maxMessageLength); // assuming keyboard buffer will alwas be limited to 1024 bytes
-    deserializeJson(keyboardBuffer, keyboard);
-    replyMarkup["keyboard"] = keyboardBuffer.as<JsonArray>();
+    replyMarkup["keyboard"] = serialized(keyboard);
   }
 
   return sendPostPhoto(payload.as<JsonObject>());

Original file line number	Diff line number	Diff line change
`@@ -741,9 +741,7 @@ String UniversalTelegramBot::sendPhoto(String chat_id, String photo,`
`741`	`741`
`742`	`742`	`if (!keyboard.isEmpty()) {`
`743`	`743`	`JsonObject replyMarkup = payload.createNestedObject("reply_markup");`
`744`		`- DynamicJsonDocument keyboardBuffer(maxMessageLength); // assuming keyboard buffer will alwas be limited to 1024 bytes`
`745`		`- deserializeJson(keyboardBuffer, keyboard);`
`746`		`- replyMarkup["keyboard"] = keyboardBuffer.as<JsonArray>();`
	`744`	`+ replyMarkup["keyboard"] = serialized(keyboard);`
`747`	`745`	`}`
`748`	`746`
`749`	`747`	`return sendPostPhoto(payload.as<JsonObject>());`