Secure isLTE and isGTE functions (#2410)

Author: Inbal-Tish

src/dateutils.spec.js

@@ -71,6 +71,22 @@ describe('dateutils', function () {
   });
 
   describe('isLTE()', function () {
+    it('a is undefined', function () {
+      const a = undefined;
+      const b = XDate(2014, 1, 20);
+      expect(isLTE(b, a)).toBe(undefined);
+    });
+
+    it('b is undefined', function () {
+      const a = XDate(2013, 12, 31);
+      const b = undefined;
+      expect(isLTE(b, a)).toBe(undefined);
+    });
+
+    it('both are undefined', function () {
+      expect(isLTE(undefined, undefined)).toBe(undefined);
+    });
+
     it('2014-01-20 >= 2013-12-31', function () {
       const a = XDate(2013, 12, 31);
       const b = XDate(2014, 1, 20);
@@ -98,6 +114,22 @@ describe('dateutils', function () {
   });
 
   describe('isGTE()', function () {
+    it('a is undefined', function () {
+      const a = undefined;
+      const b = XDate(2014, 1, 20);
+      expect(isGTE(b, a)).toBe(undefined);
+    });
+
+    it('b is undefined', function () {
+      const a = XDate(2013, 12, 31);
+      const b = undefined;
+      expect(isGTE(b, a)).toBe(undefined);
+    });
+
+    it('both are undefined', function () {
+      expect(isGTE(undefined, undefined)).toBe(undefined);
+    });
+
     it('2014-01-20 >= 2013-12-31', function () {
       const a = XDate(2013, 12, 31);
       const b = XDate(2014, 1, 20);

src/dateutils.ts

@@ -78,11 +78,15 @@ export function isToday(date?: XDate | string) {
 }
 
 export function isGTE(a: XDate, b: XDate) {
-  return b.diffDays(a) > -1;
+  if (a && b) {
+    return b.diffDays(a) > -1;
+  }
 }
 
 export function isLTE(a: XDate, b: XDate) {
-  return a.diffDays(b) > -1;
+  if (a && b) {
+    return a.diffDays(b) > -1;
+  }
 }
 
 export function formatNumbers(date: any) {