Edit:

All tests passing. Ready for review.

I suggest reading the whole description.

My other PR that need merging, it's a simple one. #2696 but unrelated to this one.

Hi,

I've refactored the code to have a single point encapsulating date functionality, that should make the code cleaner. It was a mess before, with a bunch of repetitions spread, making it harder to maintain or erven replace the implementation if that were ever needed.

https://day.js.org/

Momentjs is known to be a buggy library due to being mutable and with it's side effects. No point in supporting legacy code just because someone might want. But regardless, dayjs were designed as straight replacement.

They themselves recommend another solution https://github.com/arshaw/xdate/blob/master/README.md but thats 20kb, dayjs is only 2-3kb.

Here is a comparison between the previous and the new implementation.

XDate

• Lightweight date library with a simple API.
• Focuses on parsing, formatting, and manipulating dates.
• Supports basic operations: add/subtract, set/get parts of a date, formatting.
• No built-in support for time zones or locales.
• No longer actively maintained (last update was several years ago).
• Smaller ecosystem and less community support.
• API is very similar to the native JS Date object but adds chainability and better parsing.

Day.js

• Modern, fast, and minimalist date library (~2KB gzipped).
• API is almost a drop-in replacement for Moment.js (intentionally designed this way).
• Extensive plugin ecosystem (time zones, relative time, advanced formatting, custom parsing, durations, etc.).
• Actively maintained and widely used.
• Immutable date objects (operations return new instances, not mutate existing ones).
• Supports internationalization (i18n) with locales.
• Smaller bundle size than Moment.js, and typically more feature-rich than XDate.

Summary Table

Edits:

As I was still refactoring code, there were just a bunch of code with possible side effects, making it harder to actually know what was going on when reading.

I run the lint fix in the whole project, there were a bunch of reformat.

Much of the code were not encapsulated, and it was heavily tied to the previous libraries, it made way more difficult to migrate the library.

It appears that some components have a month property in them, yet it was tied as a XDate type, yet in one of the components, it was used as date, yet specified as just a month. So, there could have been hidden bugs in this part. Or just bad variable naming.

There seem to be a bunch of eslint and types errors, unrelated to anything I did, making it not possible to compile the project. That is not properly setup.

Btw many places lack testing, some tests were breaking and there was no clue where the issue was.

When adding tests, one should add unit tests covering all parts of it before adding any other testing that covers a different layer. This should be enforced in the project.

At this point tests in the project are all mixed up with no distinction of what type is what.

There should be a separation of files and folders naming per test type. Then enforce the coverage in the CI.

You should check LocaleConfig new implemntation. At the moment all the user need is setting the defaultLocale, the translation/i18n are automatically done by dayjs.

https://day.js.org/docs/en/i18n/changing-locale

https://day.js.org/docs/en/customization/customization

https://day.js.org/docs/en/i18n/i18n - https://github.com/iamkun/dayjs/tree/dev/src/locale

There are many bad implementations in the code, they dont make any sense and are far from clear. But, at least in the date part, it should be way clearer of what is happening. Still the implementations using it, might not be. Though I have simplified some.

It's like there were no reviews when they were added to the code.

Any project should have full enforcements of setup. Yet lint and format seems all out of place.

I see that this project lacks

• Enforcement of linting, formatting and types having to fully pass.
• Commitlint to enforce good commit messages.
• Good reviews - Maybe this would help https://www.coderabbit.ai/ - https://dev.to/crosspostr/easily-perform-ai-powered-code-reviews-in-minutes-coderabbit-github-28d3

If these two PRs are merged, I can work on another to deal with this, except on the coderabbit, of course.