updated test to work on both iOS and Android

Author: markdevocht

ios/RNNReactTitleView.mm

@@ -2,6 +2,7 @@
 
 @implementation RNNReactTitleView {
     BOOL _fillParent;
+    CGFloat _expectedHeight;
 }
 
 - (NSString *)componentType {
@@ -10,7 +11,7 @@ - (NSString *)componentType {
 
 - (CGSize)intrinsicContentSize {
     if (_fillParent) {
-        return UILayoutFittingExpandedSize;
+        return CGSizeMake(UILayoutFittingExpandedSize.width, _expectedHeight > 0 ? _expectedHeight : 44);
     } else {
         return [super intrinsicContentSize];
     }
@@ -19,6 +20,7 @@ - (CGSize)intrinsicContentSize {
 - (void)setAlignment:(NSString *)alignment inFrame:(CGRect)frame {
     if ([alignment isEqualToString:@"fill"]) {
         _fillParent = YES;
+        _expectedHeight = frame.size.height;
         self.translatesAutoresizingMaskIntoConstraints = NO;
         self.sizeFlexibility = RCTRootViewSizeFlexibilityNone;
     } else {

playground/e2e/Options.test.js

@@ -55,13 +55,13 @@ describe('Options', () => {
     await expect(elementByLabel('Title Changed')).toBeVisible();
   });
 
-  it(':android: TopBar custom title with subtitle should be visible', async () => {
+  it('TopBar custom title with subtitle should be visible', async () => {
     await elementById(TestIDs.GOTO_TOPBAR_TITLE_TEST).tap();
     await expect(elementById(TestIDs.TOPBAR_TITLE_TEXT)).toBeVisible();
     await expect(elementById(TestIDs.TOPBAR_TITLE_AVATAR)).toBeVisible();
   });
 
-  it(':android: TopBar custom title without subtitle should be visible', async () => {
+  it('TopBar custom title without subtitle should be visible', async () => {
     await elementById(TestIDs.GOTO_TOPBAR_TITLE_TEST).tap();
     await elementById(TestIDs.SET_TOPBAR_WITHOUT_SUBTITLE_BTN).tap();
     await expect(elementById(TestIDs.TOPBAR_TITLE_TEXT)).toBeVisible();

playground/src/screens/TopBarTitleTestScreen.tsx

@@ -88,7 +88,6 @@ export default class TopBarTitleTestScreen extends NavigationComponent<Props> {
                 <Button
                     label="Without Subtitle (Bug Test)"
                     testID={SET_TOPBAR_WITHOUT_SUBTITLE_BTN}
-                    platform="android"
                     onPress={this.setTopBarWithoutSubtitle}
                 />
             </Root>