Skip to content
This repository was archived by the owner on Feb 14, 2025. It is now read-only.

Commit d6fb0ad

Browse files
robmenrobmen
committed
Fix Publisher and skip signing where SHA2 unsupported
Signing service only supports signing with SHA2 so we can't sign VSIXs where VS does not support it (namely: VS2010, VS2012 VS2013).
1 parent 5d1f373 commit d6fb0ad

File tree

11 files changed

+14
-11
lines changed

11 files changed

+14
-11
lines changed

‎src/Schemas/v3/source.extension.vsixmanifest‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
33
<Metadata>
4-
<Identity Id="WixToolset.VisualStudioExtension.Schemas3" Version="|v3schemas;GetBuildVersion|" Language="en-US" Publisher=".NET Foundation and contributors" />
4+
<Identity Id="WixToolset.VisualStudioExtension.Schemas3" Version="|v3schemas;GetBuildVersion|" Language="en-US" Publisher="WiX Toolset" />
55
<DisplayName>WiX Toolset v3 Schemas for Visual Studio</DisplayName>
66
<Description>Visual Studio integraion for the WiX Toolset v3 schemas</Description>
77
<MoreInfo>http://wixtoolset.org/</MoreInfo>

‎src/Schemas/v4/source.extension.vsixmanifest‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
33
<Metadata>
4-
<Identity Id="WixToolset.VisualStudioExtension.Schemas4" Version="|v4schemas;GetBuildVersion|" Language="en-US" Publisher=".NET Foundation and contributors" />
4+
<Identity Id="WixToolset.VisualStudioExtension.Schemas4" Version="|v4schemas;GetBuildVersion|" Language="en-US" Publisher="WiX Toolset" />
55
<DisplayName>WiX Toolset v4 Schemas for Visual Studio</DisplayName>
66
<Description>Visual Studio integraion for the WiX Toolset v4 schemas</Description>
77
<MoreInfo>http://wixtoolset.org/</MoreInfo>

‎src/Votive2010/Votive2010.csproj‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
<ProjectGuid>{3FFC5AB2-97CC-48C1-A28B-CC7F1CEEE92A}</ProjectGuid>
77
<OutputType>Library</OutputType>
88
<AssemblyName>Votive2010</AssemblyName>
9-
<ShouldSignOutput>true</ShouldSignOutput>
9+
<!--- Signing only signs SHA2 and VS2010 does not support SHA2 so no signing -->
10+
<ShouldSignOutput>false</ShouldSignOutput>
1011

1112
<CopyBuildOutputToOutputDirectory>false</CopyBuildOutputToOutputDirectory>
1213
<CopyOutputSymbolsToOutputDirectory>false</CopyOutputSymbolsToOutputDirectory>

‎src/Votive2010/source.extension.vsixmanifest‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<Vsix Version="1.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2010">
33
<Identifier Id="WixToolset.VisualStudioExtension.Dev10">
44
<Name>Wix Toolset Visual Studio 2010 Extension</Name>
5-
<Author>.NET Foundation and contributors</Author>
5+
<Author>WiX Toolset</Author>
66
<Version>|Votive2010;GetBuildVersion|</Version>
77
<Locale>1033</Locale>
88
<InstalledByMsi>false</InstalledByMsi>

‎src/Votive2012/Votive2012.csproj‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
<ProjectGuid>{40F7D778-7677-4597-AF84-C956A31A9EE9}</ProjectGuid>
77
<OutputType>Library</OutputType>
88
<AssemblyName>Votive2012</AssemblyName>
9-
<ShouldSignOutput>true</ShouldSignOutput>
9+
<!--- Signing only signs SHA2 and VS2012 does not support SHA2 so no signing -->
10+
<ShouldSignOutput>false</ShouldSignOutput>
1011

1112
<CopyBuildOutputToOutputDirectory>false</CopyBuildOutputToOutputDirectory>
1213
<CopyOutputSymbolsToOutputDirectory>false</CopyOutputSymbolsToOutputDirectory>

‎src/Votive2012/source.extension.vsixmanifest‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<Vsix Version="1.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2010">
33
<Identifier Id="WixToolset.VisualStudioExtension.Dev11">
44
<Name>Wix Toolset Visual Studio 2012 Extension</Name>
5-
<Author>.NET Foundation and contributors</Author>
5+
<Author>WiX Toolset</Author>
66
<Version>|Votive2012;GetBuildVersion|</Version>
77
<Locale>1033</Locale>
88
<InstalledByMsi>false</InstalledByMsi>

‎src/Votive2013/Votive2013.csproj‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
<ProjectGuid>{0877C6F6-73D9-46F1-89AB-43B6EC05EB9F}</ProjectGuid>
77
<OutputType>Library</OutputType>
88
<AssemblyName>Votive2013</AssemblyName>
9-
<ShouldSignOutput>true</ShouldSignOutput>
9+
<!--- Signing only signs SHA2 and VS2013 does not support SHA2 so no signing -->
10+
<ShouldSignOutput>false</ShouldSignOutput>
1011

1112
<CopyBuildOutputToOutputDirectory>false</CopyBuildOutputToOutputDirectory>
1213
<CopyOutputSymbolsToOutputDirectory>false</CopyOutputSymbolsToOutputDirectory>

‎src/Votive2013/source.extension.vsixmanifest‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<Vsix Version="1.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2010">
33
<Identifier Id="WixToolset.VisualStudioExtension.Dev12">
44
<Name>Wix Toolset Visual Studio 2013 Extension</Name>
5-
<Author>.NET Foundation and contributors</Author>
5+
<Author>WiX Toolset</Author>
66
<Version>|Votive2013;GetBuildVersion|</Version>
77
<Locale>1033</Locale>
88
<InstalledByMsi>false</InstalledByMsi>

‎src/Votive2015/source.extension.vsixmanifest‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<Vsix Version="1.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2010">
33
<Identifier Id="WixToolset.VisualStudioExtension.Dev14">
44
<Name>Wix Toolset Visual Studio 2015 Extension</Name>
5-
<Author>.NET Foundation and contributors</Author>
5+
<Author>WiX Toolset</Author>
66
<Version>|Votive2015;GetBuildVersion|</Version>
77
<Locale>1033</Locale>
88
<InstalledByMsi>false</InstalledByMsi>

‎src/Votive2017/source.extension.vsixmanifest‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
33
<Metadata>
4-
<Identity Id="WixToolset.VisualStudioExtension.Dev15" Version="|Votive2017;GetBuildVersion|" Language="en-US" Publisher=".NET Foundation and contributors" />
4+
<Identity Id="WixToolset.VisualStudioExtension.Dev15" Version="|Votive2017;GetBuildVersion|" Language="en-US" Publisher="WiX Toolset" />
55
<DisplayName>Wix Toolset Visual Studio 2017 Extension</DisplayName>
66
<Description>Visual Studio integration for the WiX Toolset - the most powerful set of tools available to create your Windows installation experience.</Description>
77
<MoreInfo>http://wixtoolset.org/</MoreInfo>

0 commit comments

Comments
 (0)