Converting from v3 to v4

[Falkesand]

Hi,

we have an issue with the converter that we can't wrap our heads around.

Our Product.wxs starts like this:

<?xml version="1.0" encoding="UTF-8"?>
<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi"
     xmlns:iis="http://schemas.microsoft.com/wix/IIsExtension"
     xmlns:util="http://schemas.microsoft.com/wix/UtilExtension">

  <Product Id="*" Name="asas" Language="1033" Version="!(bind.FileVersion.asas.Webservice.dll)" Manufacturer="asas" UpgradeCode="asas">
    <Package InstallerVersion="500" Compressed="yes" InstallPrivileges="elevated" InstallScope="perMachine" />

If we have xmlns:util="http://schemas.microsoft.com/wix/UtilExtension" as attribute in <Wix xxxx/> we get the following error.

wix.exe : error WIX0001: System.InvalidOperationException: Duplicate attribute.
at System.Xml.Linq.XElement.AddAttributeSkipNotify(XAttribute a)
at System.Xml.Linq.XContainer.AddContentSkipNotify(Object content)
at System.Xml.Linq.XContainer.Add(Object content)
at WixToolset.Converters.WixConverter.ConvertInnerTextToAttribute(XElement element, String attributeName) in D:\a\wix4\wix4\src\wix\WixToolset.Converters\WixConverter.cs:line 2044
at WixToolset.Converters.WixConverter.ConvertPropertyElement(XElement xProperty) in D:\a\wix4\wix4\src\wix\WixToolset.Converters\WixConverter.cs:line 1944
at WixToolset.Converters.WixConverter.ConvertElement(XElement element) in D:\a\wix4\wix4\src\wix\WixToolset.Converters\WixConverter.cs:line 618
at WixToolset.Converters.WixConverter.ConvertNodes(IEnumerable1 nodes, Int32 level) in D:\a\wix4\wix4\src\wix\WixToolset.Converters\WixConverter.cs:line 512 at WixToolset.Converters.WixConverter.ConvertNodes(IEnumerable1 nodes, Int32 level) in D:\a\wix4\wix4\src\wix\WixToolset.Converters\WixConverter.cs:line 516
at WixToolset.Converters.WixConverter.ConvertNodes(IEnumerable1 nodes, Int32 level) in D:\a\wix4\wix4\src\wix\WixToolset.Converters\WixConverter.cs:line 516 at WixToolset.Converters.WixConverter.Convert(XDocument document) in D:\a\wix4\wix4\src\wix\WixToolset.Converters\WixConverter.cs:line 403 at WixToolset.Converters.WixConverter.ConvertFile(String sourceFile, Boolean saveConvertedFile) in D:\a\wix4\wix4\src\wix\WixToolset.Converters\WixConverter.cs:line 325 at WixToolset.Converters.ConvertCommand.<>c__DisplayClass3_0.<ExecuteAsync>g__Inspector|0(String file, Boolean fix) in D:\a\wix4\wix4\src\wix\WixToolset.Converters\ConvertCommand.cs:line 46 at WixToolset.Converters.FixupCommandBase.InspectSubDirectories(Func3 inspector, String directory, CancellationToken cancellationToken) in D:\a\wix4\wix4\src\wix\WixToolset.Converters\FixupCommandBase.cs:line 168
at WixToolset.Converters.FixupCommandBase.Inspect(Func`3 inspector, CancellationToken cancellationToken) in D:\a\wix4\wix4\src\wix\WixToolset.Converters\FixupCommandBase.cs:line 137
at WixToolset.Converters.ConvertCommand.ExecuteAsync(CancellationToken cancellationToken) in D:\a\wix4\wix4\src\wix\WixToolset.Converters\ConvertCommand.cs:line 40
at WixToolset.Tools.Program.Run(IServiceProvider serviceProvider, IMessageListener listener, String[] args, CancellationToken cancellationToken) in D:\a\wix4\wix4\src\wix\wix\Program.cs:line 89
at WixToolset.Tools.Program.Main(String[] args) in D:\a\wix4\wix4\src\wix\wix\Program.cs:line 43

If we removes the utilExtension it doesn't throw the error on convert, but it doesn't convert it either.

Anyone got any idea whats happening ?

[rseanhall]

You can see in the call stack that it's having trouble with a Property element: WixToolset.Converters.WixConverter.ConvertPropertyElement. Please create a bug for this, but you'll need to provide the whole file or do more work to provide a simplified example of what's causing the issue.

[robmen]

@rseanhall is right about opening a bug, click here.

The first quick thing to look for is a Property element in your .wxs code with a Value attribute on it and with some text between. Like:

<Property Id="Something" Value="A value">Some text</Property>

If so, adding the matching line to the bug would be helpful. Otherwise, as much information as you can provide would be good.

[Falkesand]

Thanks, bug reported

[Falkesand]

Reported it as a bug here : #7028