The "ResolvePackageDependencies" task failed unexpectedly.

[mickderks]

Hi. In an effort to get all our projects over to using PackageReferences I've been trying to get a head start on a Wix4 migration. I'm running into an issue where VS throws up an error while trying to restore NuGet packages for the converted Wix projects.

The error seems to be HeatWave choking on log entries like the following in the project.assets.json file;

    {
      "code": "NU1701",
      "level": "Warning",
      "warningLevel": 1,
      "message": "Package 'System.Security.Permissions 4.7.0' was restored using 'net7.0-windows7.0, net7.0-windows, net7.0, net6.0-windows7.0, net6.0-windows, net6.0, net5.0-windows7.0, net5.0-windows, net5.0, .NETCoreApp,Version=v3.1, .NETCoreApp,Version=v3.0, .NETCoreApp,Version=v2.0, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, native,Version=v0.0' instead of the project target framework 'native,Version=v0.0'. This package may not be fully compatible with your project.",
      "libraryId": "System.Security.Permissions",
      "targetGraphs": [
        "native,Version=v0.0"
      ]
    },

I don't know if this is an actual issue with Wix, or that NuGet is breaking due to the project, my setup, or some other reason. I've been unable to reproduce the issue with a small-scale test project. With a .NET Framework 4.7.2 project, or a .NET 6.0 project.

The project being converted is a .NET Framework 4.7.2 project.
VS 2022 17.4.2
Wix 4.0.0-rc.1
HeatWave 0.9.2

Error	MSB4018	The "ResolvePackageDependencies" task failed unexpectedly.
System.ArgumentException: Invalid framework version '0.0/win'.
   at NuGet.Frameworks.NuGetFramework.ParseFrameworkNameParts(IFrameworkNameProvider mappings, String[] parts, String& framework, Version& version, String& profile)
   at NuGet.Frameworks.NuGetFramework.ParseFrameworkName(String frameworkName, IFrameworkNameProvider mappings)
   at NuGet.Frameworks.NuGetFramework.Parse(String folderName, IFrameworkNameProvider mappings)
   at FireGiant.HeatWave.Build.Tasks.ResolvePackageDependencies.<GetPackageAndFileDefinitions>b__48_5(String tg)
   at System.Linq.Enumerable.WhereSelectListIterator`2.MoveNext()
   at System.Linq.Enumerable.Contains[TSource](IEnumerable`1 source, TSource value, IEqualityComparer`1 comparer)
   at System.Linq.Enumerable.WhereListIterator`1.MoveNext()
   at System.Linq.Enumerable.Any[TSource](IEnumerable`1 source)
   at FireGiant.HeatWave.Build.Tasks.ResolvePackageDependencies.<GetPackageAndFileDefinitions>g__GetPackageDiagnosticLevel|48_0(LockFileLibrary package)
   at FireGiant.HeatWave.Build.Tasks.ResolvePackageDependencies.GetPackageAndFileDefinitions()
   at Microsoft.NET.Build.Tasks.TaskBase.Execute()
   at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
   at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext()	Kodision.TriplEforms.Setup.ManagementConsole	C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\FireGiant\HeatWave\FireGiant.HeatWave.PackageDependencyResolution.targets	185	

I've unfortunately needed to do some redacting in the project.assets.json file;

{
  "version": 3,
  "targets": {
    "native,Version=v0.0": { ... },
    "native,Version=v0.0/win": { ... },
    "native,Version=v0.0/win-x64": { ... },
    "native,Version=v0.0/win-x86": { ... }
  },
  "libraries": { ... },
  "projectFileDependencyGroups": {
    "native,Version=v0.0": [
      "... >= 1.0.0",
      "WixToolset.NetFx.wixext >= 4.0.0-rc.1",
      "WixToolset.UI.wixext >= 4.0.0-rc.1",
      "WixToolset.Util.wixext >= 4.0.0-rc.1",
      "WixToolset.VisualStudio.wixext >= 4.0.0-rc.1"
    ]
  },
  "packageFolders": {
    "C:\\Users\\...\\.nuget\\packages\\": {}
  },
  "project": {
    "version": "1.0.0",
    "restore": { ... },
	"frameworks": {
      "native": {
        "targetAlias": "native",
        "dependencies": {
          "WixToolset.NetFx.wixext": {
            "target": "Package",
            "version": "[4.0.0-rc.1, )"
          },
          "WixToolset.UI.wixext": {
            "target": "Package",
            "version": "[4.0.0-rc.1, )"
          },
          "WixToolset.Util.wixext": {
            "target": "Package",
            "version": "[4.0.0-rc.1, )"
          },
          "WixToolset.VisualStudio.wixext": {
            "target": "Package",
            "version": "[4.0.0-rc.1, )"
          }
        },
        "imports": [
          "net7.0-windows7.0",
          "net7.0-windows",
          "net7.0",
          "net6.0-windows7.0",
          "net6.0-windows",
          "net6.0",
          "net5.0-windows7.0",
          "net5.0-windows",
          "net5.0",
          "netcoreapp3.1",
          "netcoreapp3.0",
          "netcoreapp2.0",
          "net462",
          "net47",
          "net471",
          "net472",
          "net48",
          "native"
        ],
        "assetTargetFallback": true,
        "warn": true
      }
    },
    "runtimes": {
      "win": {
        "#import": []
      },
      "win-x64": {
        "#import": []
      },
      "win-x86": {
        "#import": []
      }
    }
  },
  "logs": [ ... ]
}

[robmen]

This issue is probably the most significant remaining challenge in WiX v4. We've started conversations with Microsoft on how to solve the root issue best, and we plan will continue now that the holidays are over.

I should open an issue tracking the issue. I'll do that now.

[rseanhall]

#7132