Wix v4 Burn - Image Control in a page is visible in other pages

[wmanning]

I'm using a custom theme based on HyperlinkTheme.wxl and WixStdBA.
I have an ImageControl below the <Window> element and it shows up all the time as expected.

I have another ImageControl below the <Page Name="Install"> element and the:

• image is shown when first open installer without the bundle installed as expected.
• image is hidden during install progress and install success as expected
• BUT when I open the installer again after the bundle has installed the image is shown. I would expect it to be hidden. Same with uninstall progress.

Can't figure out why it would be hidden with Install, install progress, and install success but shown during modify.

I have to add a VisibleCondition="NOT WixBundleInstalled" condition to the ImageControl element to prevent it from showing up in Modify, etc.

Am I doing something wrong?

Details on my authoring:

<BootstrapperApplication>
      <bal:WixStandardBootstrapperApplication LicenseUrl="" SuppressOptionsUI="yes" ThemeFile="$(sys.CURRENTDIR)Theme\Theme.xml" LocalizationFile="$(sys.CURRENTDIR)Theme\Theme.wxl" Theme="hyperlinkLicense" />
      <Payload Name="dynaLogo.png" Compressed="yes" SourceFile="$(sys.CURRENTDIR)Theme\dynaLogo.png" />
      <Payload Name="rcLogo.png" Compressed="yes" SourceFile="$(sys.CURRENTDIR)Theme\rcLogo.png" />
      <Payload Name="icon.ico" Compressed="yes" SourceFile="$(sys.CURRENTDIR)Files\icon.ico" />
</BootstrapperApplication>

The theme xml file is standard with 4 changes (only showing the top half that contains the changes):

<?xml version="1.0" encoding="utf-8"?>
<!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the Microsoft Reciprocal License. See LICENSE.TXT file in the project root for full license information. -->


<Theme xmlns="http://wixtoolset.org/schemas/v4/thmutil">
    <Font Id="0" Height="-12" Weight="500" Foreground="windowtext" Background="window">Segoe UI</Font>
    <Font Id="1" Height="-24" Weight="500" Foreground="windowtext">Segoe UI</Font>
    <Font Id="2" Height="-22" Weight="500" Foreground="graytext">Segoe UI</Font>
    <Font Id="3" Height="-12" Weight="500" Foreground="windowtext" Background="window">Segoe UI</Font>

    <Window Width="480" Height="205" HexStyle="100a0000" FontId="0" Caption="#(loc.Caption)">
        <ImageControl X="285" Y="11" Width="175" Height="45" ImageFile="dynaLogo.png" Visible="yes"></ImageControl>
        <!--<ImageControl X="11" Y="11" Width="64" Height="64" ImageFile="logo.png" Visible="yes"/>-->
        <!--<Label X="80" Y="11" Width="-11" Height="64" FontId="1" Visible="yes" DisablePrefix="yes">#(loc.Title)</Label>-->

        <Page Name="Help">
            <Label X="11" Y="80" Width="-11" Height="30" FontId="2" DisablePrefix="yes">#(loc.HelpHeader)</Label>
            <Label X="11" Y="112" Width="-11" Height="-35" FontId="3" DisablePrefix="yes">#(loc.HelpText)</Label>
            <Button Name="HelpCloseButton" X="-11" Y="-11" Width="75" Height="23" TabStop="yes" FontId="0">
                <Text>#(loc.HelpCloseButton)</Text>
                <CloseWindowAction />
            </Button>
        </Page>
        <Page Name="Loading">
            <Label X="11" Y="80" Width="-11" Height="30" FontId="2" DisablePrefix="yes" Visible="no" Name="CheckingForUpdatesLabel" />
        </Page>
        <Page Name="Install">
            <ImageControl X="0" Y="0" Width="210" Height="190" ImageFile="rcLogo.png" Visible="yes"></ImageControl>
            <Label X="15" Y="185" Width="200" Height="15" FontId="3">#(loc.InstallVersion)</Label>
            <Hypertext Name="EulaHyperlink" X="11" Y="121" Width="-11" Height="51" TabStop="yes" FontId="3" HideWhenDisabled="yes">#(loc.InstallLicenseLinkText)</Hypertext>
            <Checkbox Name="EulaAcceptCheckbox" X="-11" Y="-41" Width="260" Height="17" TabStop="yes" FontId="3" HideWhenDisabled="yes">#(loc.InstallAcceptCheckbox)</Checkbox>
            <Button Name="InstallUpdateButton" X="11" Y="-11" Width="200" Height="23" TabStop="yes" FontId="0" EnableCondition="WixStdBAUpdateAvailable" HideWhenDisabled="yes">#(loc.UpdateButton)</Button>
            <Button Name="OptionsButton" X="-171" Y="-11" Width="75" Height="23" TabStop="yes" FontId="0" VisibleCondition="NOT WixStdBASuppressOptionsUI">
                <Text>#(loc.InstallOptionsButton)</Text>
                <ChangePageAction Page="Options" />
            </Button>
            <Button Name="InstallButton" X="-91" Y="-11" Width="75" Height="23" TabStop="yes" FontId="0">#(loc.InstallInstallButton)</Button>
            <Button Name="InstallCancelButton" X="-11" Y="-11" Width="75" Height="23" TabStop="yes" FontId="0">
                <Text>#(loc.InstallCancelButton)</Text>
                <CloseWindowAction />
            </Button>
        </Page>

[barnson]

Any change if you remove VisibleCondition?

[wmanning]

Sorry my bad. The theme xml I posted above is the version that's working as I expect. I edited my post to add the theme that does not work.

The theme doesn't work as I expected until I add in the VisibleCondition.

[barnson]

That sounds like a bug. Can you open an issue with a repro?

[wmanning]

I will open an issue now. Repo I will try to do on week of 17th as I'm on vacation next week.
And by repo I assume you mean a complete solution consisting of a burn project with custom theme installing something (say an MSI)?

[barnson]

Theme alone would be fine, I think, along with graphics (or placeholders of the right size). I've used ThmViewer before to debug ThmUtil bugs.

[rseanhall]

Don't use Visible="yes" for controls on a page. Maybe this can be fixed, but I would bet that it worked this way in v3 as well since the sidebar themes include ImageControls inside of pages and they do not include Visible="yes".

[barnson]

That's interesting...I wonder if Visible even makes sense for paged controls...

[wmanning]

@rseanhall @barnson
Yep Removing Visible="yes" works. No longer need the VisibleCondition="NOT WixBundleInstalled" condition.