[Wix4] RelatedBundle element causes access violation crash

[lukeskrz]

Hello,
I recently installed the 4.0.0.0 release version of Wix and converted our existing bundle (built with Wix 3) to Wix 4.
Upon trying to run it, it immediately crashed with an access violation

Exception thrown at 0x005919A9 in MyApp.exe: 0xC0000005: Access violation writing location 0x00000001.

I was able to debug it with Visual Studio and got this callstack

MyApp.exe!BundlePackageEngineParseRelatedCodes(IXMLDOMNode * pixnBundle, wchar_t * * * prgsczDetectCodes, unsigned long * pcDetectCodes, wchar_t * * * prgsczUpgradeCodes, unsigned long * pcUpgradeCodes, wchar_t * * * prgsczAddonCodes, unsigned long * pcAddonCodes, wchar_t * * * prgsczPatchCodes, unsigned long * pcPatchCodes) Line 138	C++
MyApp.exe!RegistrationParseFromXml(_BURN_REGISTRATION * pRegistration, _BURN_CACHE * pCache, IXMLDOMNode * pixnBundle) Line 144	C++
MyApp.exe!ParseFromXml(IXMLDOMDocument * pixdDocument, _BURN_ENGINE_STATE * pEngineState) Line 128	C++
MyApp.exe!ManifestLoadXmlFromBuffer(unsigned char * pbBuffer, unsigned long cbBuffer, _BURN_ENGINE_STATE * pEngineState) Line 55	C++
MyApp.exe!CoreInitialize(_BURN_ENGINE_STATE * pEngineState) Line 120	C++
MyApp.exe!EngineRun(HINSTANCE__ * hInstance, void * hEngineFile, const wchar_t * wzCommandLine, int nCmdShow, unsigned long * pdwExitCode) Line 211	C++
MyApp.exe!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * __formal, wchar_t * lpCmdLine, int nCmdShow) Line 56	C++
[Inline Frame] MyApp.exe!invoke_main() Line 118	C++
MyApp.exe!__scrt_common_main_seh() Line 288	C++
kernel32.dll!@BaseThreadInitThunk@12�()	Unknown
ntdll.dll!__RtlUserThreadStart()	Unknown
ntdll.dll!__RtlUserThreadStart@8�()	Unknown

That seems to resolve to this code:

...
    hr = XmlSelectNodes(pixnBundle, L"RelatedBundle", &pixnNodes);
    ExitOnFailure(hr, "Failed to get RelatedBundle nodes");

    hr = pixnNodes->get_length((long*)&cElements);
    ExitOnFailure(hr, "Failed to get RelatedBundle element count.");

    for (DWORD i = 0; i < cElements; ++i)   // <-- exception around here
    {
        hr = XmlNextElement(pixnNodes, &pixnElement, NULL);
        ExitOnFailure(hr, "Failed to get next RelatedBundle element.");
...

This is the line that we have in our Bundle.wxs file:
<RelatedBundle Id="<guid>" Action="upgrade" />

I tried removing the RelatedBundle line and the crash immediately went away.
Strange thing is that cElements was set to 2, even though we only had the one RelatedBundle node.

Is this a known issue, or are we doing something wrong? I can also provide a dump file if needed.

[barnson]

Please open an issue. I'm going to take the controversial stance that crashes are bad. :)

[lukeskrz]

Thanks, created #7451