Migrating Custom FeatureTree Dialogs from v3 to v4

[melsawy93]

Hi, I just migrated my wix installer (previously working) from v3 to v4. I did this manually and compared it to a project that was upgraded using the extension. I fixed the majority of the warnings/errors however I am not able to get my Custom_FeatureTree to work. I tried to follow the documentation but I must be missing something.

Here is my Custom_FeatureTree.wxs:

<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs">
  <?foreach WIXUIARCH in X86;X64;A64 ?>
  <Fragment>
    <UI Id="Custom_FeatureTree_$(WIXUIARCH)">
      <Publish Dialog="LicenseAgreementDlg" Control="Print" Event="DoAction" Value="WixUIPrintEula_$(WIXUIARCH)" />
    </UI>

    <UIRef Id="Custom_FeatureTree" />
  </Fragment>
  <?endforeach?>

  <Fragment>
    <UI Id="file Custom_FeatureTree">
      <TextStyle Id="WixUI_Font_Normal" FaceName="Tahoma" Size="8" />
      <TextStyle Id="WixUI_Font_Bigger" FaceName="Tahoma" Size="12" />
      <TextStyle Id="WixUI_Font_Title" FaceName="Tahoma" Size="9" Bold="yes" />

      <Property Id="DefaultUIFont" Value="WixUI_Font_Normal" />

      <DialogRef Id="ErrorDlg" />
      <DialogRef Id="FatalError" />
      <DialogRef Id="FilesInUse" />
      <DialogRef Id="MsiRMFilesInUse" />
      <DialogRef Id="PrepareDlg" />
      <DialogRef Id="ProgressDlg" />
      <DialogRef Id="ResumeDlg" />
      <DialogRef Id="UserExit" />
      <DialogRef Id="UserInputDlg" />

      <Publish Dialog="ExitDialog" Control="Finish" Event="EndDialog" Value="Return" Order="999" />

      <Publish Dialog="WelcomeDlg" Control="Next" Event="NewDialog" Value="LicenseAgreementDlg" Condition="NOT Installed" />
      <Publish Dialog="WelcomeDlg" Control="Next" Event="NewDialog" Value="VerifyReadyDlg" Condition="Installed AND PATCH" />

      <Publish Dialog="LicenseAgreementDlg" Control="Back" Event="NewDialog" Value="WelcomeDlg" />
      <!--<Publish Dialog="LicenseAgreementDlg" Control="Next" Event="NewDialog" Value="CustomizeDlg" Condition="LicenseAccepted = &quot;1&quot;" />-->
      <Publish Dialog="LicenseAgreementDlg" Control="Next" Event="NewDialog" Value="UserInputDlg" Condition="LicenseAccepted = &quot;1&quot;" />
      
      <!--Modified portion here -->
      <Publish Dialog="UserInputDlg" Control="Back" Event="NewDialog" Value="MaintenanceTypeDlg" Order="1" Condition="Installed" />
      <Publish Dialog="UserInputDlg" Control="Back" Event="NewDialog" Value="LicenseAgreementDlg" Order="2" Condition="NOT Installed" />
      <Publish Dialog="UserInputDlg" Control="Back" Event="NewDialog" Value="LicenseAgreementDlg" Condition="Installed" />
      <Publish Dialog="UserInputDlg" Control="Next" Event="NewDialog" Value="VerifyReadyDlg" />
      <!--Modified portion here -->
      
      <!--<Publish Dialog="CustomizeDlg" Control="Back" Event="NewDialog" Value="MaintenanceTypeDlg" Order="1" Condition="Installed" />
      <Publish Dialog="CustomizeDlg" Control="Back" Event="NewDialog" Value="LicenseAgreementDlg" Order="2" Condition="NOT Installed" />
      <Publish Dialog="CustomizeDlg" Control="Next" Event="NewDialog" Value="VerifyReadyDlg" />-->

      <!--<Publish Dialog="VerifyReadyDlg" Control="Back" Event="NewDialog" Value="CustomizeDlg" Order="1" Condition="NOT Installed OR WixUI_InstallMode = &quot;Change&quot;" />-->
      <Publish Dialog="VerifyReadyDlg" Control="Back" Event="NewDialog" Value="UserInputDlg" Order="1" Condition="NOT Installed OR WixUI_InstallMode = &quot;Change&quot;" />
      <Publish Dialog="VerifyReadyDlg" Control="Back" Event="NewDialog" Value="MaintenanceTypeDlg" Order="2" Condition="Installed AND NOT PATCH" />
      <Publish Dialog="VerifyReadyDlg" Control="Back" Event="NewDialog" Value="WelcomeDlg" Order="3" Condition="Installed AND PATCH" />

      <Publish Dialog="MaintenanceWelcomeDlg" Control="Next" Event="NewDialog" Value="MaintenanceTypeDlg" />

      <!--<Publish Dialog="MaintenanceTypeDlg" Control="ChangeButton" Event="NewDialog" Value="CustomizeDlg" />-->
      <Publish Dialog="MaintenanceTypeDlg" Control="RepairButton" Event="NewDialog" Value="VerifyReadyDlg" />
      <Publish Dialog="MaintenanceTypeDlg" Control="RemoveButton" Event="NewDialog" Value="VerifyReadyDlg" />
      <Publish Dialog="MaintenanceTypeDlg" Control="Back" Event="NewDialog" Value="MaintenanceWelcomeDlg" />
    </UI>

    <UIRef Id="WixUI_Common" />
  </Fragment>
</Wix>

I then combine this with my UserInputDlg.wxs in my UI.wxs via this:

<?xml version="1.0" encoding="UTF-8"?>
<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs">
  <Fragment>
    <!-- All UI here -->

    <UI Id="UIFile">
      <UIRef Id="file Custom_FeatureTree" />
      <UIRef Id="UserInputDlgFile" />
    </UI>
  </Fragment>
</Wix>

And finally import a ref into my Product.wxs (mainfile):

    <!-- UI file reference -->
    <UIRef Id="UIFile" />

I am currently getting this error:
Severity Code Description Project File Line Suppression State
Error WIX0014 The UIRef/@id attribute's value, 'file Custom_FeatureTree', is not a legal identifier. Identifiers may contain ASCII characters A-Z, a-z, digits, underscores (_), or periods (.). Every identifier must begin with either a letter or an underscore.

I tried changing the UI.wxs to by removing "file":

<UI Id="UIFile">
  <UIRef Id="Custom_FeatureTree" />
  <UIRef Id="UserInputDlgFile" />
</UI>

Then the error becomes:
Severity Code Description Project File Line Suppression State
Error WIX0094 The identifier 'WixUI:Custom_FeatureTree' is inaccessible due to its protection level.

[melsawy93]

Fixed.

UI.wxs:

<ui:WixUI Id="Custom_FeatureTree" />