Wixlib ExePackage Issues

[chrpai]

I have the following v3 code that compiles and works:

<?xml version="1.0" encoding="utf-8"?>
<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi" xmlns:util="http://schemas.microsoft.com/wix/UtilExtension">
	<Fragment>
		<util:RegistrySearch Id="findDOTNETVersion" Root="HKLM" Key="SOFTWARE\dotnet\Setup\InstalledVersions\x64\sharedhost" Value="Version" Result="value" Variable="DOTNETVERSION" Win64="yes" />
		<util:RegistrySearch Id="findDOTNETDesktop" Root="HKLM" Key="SOFTWARE\dotnet\Setup\InstalledVersions\x64\sharedfx\Microsoft.WindowsDesktop.App" Result="exists" Variable="DOTNETDESKTOP602INSTALLED" Win64="no" />
		<PackageGroup Id="DotNetDesktop6022Redist">
			<ExePackage Id="DotNetDesktop602"
							  DownloadUrl="https://download.visualstudio.microsoft.com/download/pr/efa32b7a-6eec-4d97-9cdc-c7336a29a749/3df4296170397cf60884dae1be3d103b/windowsdesktop-runtime-6.0.2-win-x64.exe"
							  Name="Windows Desktop Runtime Environment - 6.0.2 (x64)"
							  InstallCommand="windowsdesktop-runtime-6.0.2-win-x64.exe /install /quiet /norestart"
							  RepairCommand="windowsdesktop-runtime-6.0.2-win-x64.exe /repair /quiet /norestart"
							  UninstallCommand="windowsdesktop-runtime-6.0.2-win-x64.exe /uninstall /quiet /norestart"
							  DetectCondition="DOTNETDESKTOP602INSTALLED and DOTNETVERSION >= &quot;6.0.2&quot;"
							  SuppressSignatureVerification="yes"
							  Permanent="yes"
							  Vital="no">
				<RemotePayload CertificatePublicKey="13D6BFE4ADC9AD828EC78546ECEDE746B44C863F" CertificateThumbprint="921263EA40B2C7592E8CC1C1A4EF66E64D511674" Description="Microsoft Windows Desktop Runtime - 6.0.2 (x64)" Hash="EA8DB9D01555D0EA2A3D3CD41D56A28199A064F5" ProductName="Microsoft Windows Desktop Runtime - 6.0.2 (x64)" Size="57296456" Version="6.0.2.30914" />
			</ExePackage>
		</PackageGroup>
	</Fragment>
</Wix>

I then use heatwave/wixcop to convert to v4 and that's where I start to have issues and questions.

1. error WIX0033: Breaking change: util:RegistrySearch for a value no longer clears the variable when the key or value is missing. See the conversion FAQ for more information: https://wixtoolset.org/docs/fourthree/faqs/#converting-bundles (UtilRegistryValueSearchBehaviorChange) --- I read the FAQ and I didn't really absorb anything on what I should do if anything. This doesn't seem to be a compile break post install either so should it be a warning?

2. When I try to compile I get: WIX0035 The ExePackagePayload/@hash attribute cannot be specified when attribute CertificatePublicKey is present. - Should WiXCop have caught this? I also read that it's SHA512 now instead of SHA1 so it seems like this should have been another error/warning and possibly nulling out the value so it's no longer valid. Regardless, I remove the attribute to proceed.

3. The wixlib now builds successfully so I go ahead and create a bundle project to consume it. The bundle build fails with WIX0010 The ExePackage/@cacheid attribute was not found; it is required when attribute CertificatePublicKey is specified. That's strange... shouldn't the wixlib failed to have built for the same reason? I go ahead and add CacheId="test" and it all builds.

4. Now I go to upate this fragment from 6.0.2 to 6.0.22. I get the URL, download the file and find wix burn remotepayload. I see that it says certificate validation is not reccomended but I try it anyways since I've had experiences in the past where Microsoft decided to re-release something to the same URL. In this scenario the hash check failed but the cert check worked. Since, as stupid as that is, that's what they intended... I went with it. Since the size and version could change I decide to remove those attributes. Again the wixlib builds but the bundle fails with: WIX0001 System.InvalidOperationException: Nullable object must have a value. This error goes away when I put version back in.

5. I ditched the RegistrySearch and moved on to netfx:DotNetCoreSearch. When I first tested I got this error: . Error 0x800700c1: Failed to load BundleExtension DLL 'Wix4NetfxBundleExtension_X86' It seems to be because I built my wixlib as x86 and my bundle as x64. When I rebuilt the wixlib as x64 the problem went away. But is this correct? It seems like the wixlib should be platform independent so that whoever consumes it will set the bitness.

I atleast one issue to file here.. but maybe a few more. What say you all?

[chrpai]

Added a #5