Wix 3.11 Service always uninstalls when doing updates

[nikryden]

Try to fix a bug in one of our installation package that installs a service. The problem is that when doing an update (even with minor update) the service is uninstalled and then installed, as no data is saved in the register it always re-installs with account LocalSystem.
It has not been a problem before as the service has always been installed with the LocalSystem or the customer have not update the product, but now there is a need to update where it been installed with different Account and I have not find any good solution to fix this.

As it have been installed with different account the best solution have been if the service never will be uninstalled just stoped except on uninstall but I have not found any solution for that that's works.

I know I can save the settings in the register and it will fix it in the future, but there is some problems that we already have customer that have installed with different service account.

I have tested with many different things but nothing have worked.

I must say that I have not write the original code and have limit knowledge about Wix so i may have some problem to answer any question why it's done like it's done, I learn something new every day :).

Here is my code right now, it have been many iterations:

<?xml version="1.0" encoding="UTF-8"?>
<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi"
          xmlns:util="http://schemas.microsoft.com/wix/UtilExtension">
  <Product Id="*" Name="ServiceData" Language="1033" Version="!(bind.FileVersion.ServiceData.dll)" Manufacturer="Some Company AB" UpgradeCode="c02ba94d-c03e-4509-bc8c-5f342c2b92fd">
    <Package InstallerVersion="500" Compressed="yes" InstallPrivileges="elevated" InstallScope="perMachine" />

    <MajorUpgrade Schedule="afterInstallValidate" AllowSameVersionUpgrades="no" AllowDowngrades="no" DowngradeErrorMessage="A newer version of [ProductName] is already installed." />
    <MediaTemplate EmbedCab="yes" />

    <Condition Message="A newer version of [ProductName] is
         already installed. Exiting installation.">
      <![CDATA[Installed OR NOT NEWER_VERSION_FOUND]]>
    </Condition>


    <Upgrade Id="c02ba94d-c03e-4509-bc8c-5f342c2b92fd">
      <UpgradeVersion
           Property="OLD_VERSION_FOUND"
           Minimum="0.0.0"
           Maximum="!(bind.FileVersion.ServiceData.dll)"
           IncludeMinimum="yes"
           IncludeMaximum="no"
           OnlyDetect="no"
           IgnoreRemoveFailure="yes"
           MigrateFeatures="yes"
           Language="1033" />

      <UpgradeVersion
         Property="NEWER_VERSION_FOUND"
         Minimum="!(bind.FileVersion.ServiceData.dll)"
         IncludeMinimum="no"
         OnlyDetect="yes"
         Language="1033" />
    </Upgrade>

    <Feature Id="MainApplication" Title="Msi" Level="1" ConfigurableDirectory="INSTALLFOLDER">
      <ComponentGroupRef Id="ProductComponents" />
    </Feature>

    <Property Id='INSTALLFOLDER'>
      <RegistrySearch Id='InstallFolder' Root='HKLM'
                      Key='SOFTWARE\Company\ServiceDataInstall'
                      Name='InstallFolder' Type='raw' />
    </Property>
    <Feature Id='MainFeature' Level='1'>
      <Component Directory='INSTALLFOLDER'>
        <RegistryValue Root='HKLM' Key='SOFTWARE\Company\ServiceDataInstall'
                       Name='InstallFolder' Value='[INSTALLFOLDER]'
                       Type='string' />
        <RemoveFolder Id='CleanupApplicationFolder' On='uninstall' />
      </Component>
    </Feature>

    <Property Id="ARPNOMODIFY" Value="yes" Secure="yes" />
    <Property Id="ASSERVICE" Value="true" Secure="yes" />

    <Property Id="SERVICENAME" Secure="yes" Value="ServiceData">
      <RegistrySearch Id='Remember_servicename' Root='HKLM'
                Key='SOFTWARE\Company\ServiceData'
                Name='servicename' Type='raw' />
    </Property>

    <Property Id="SERVICEPASSWORD" Secure="yes" />
    <Property Id="SERVICEACCOUNT" Secure="yes" Value="LocalSystem" />
  

    <SetProperty Id="StartWinServiceFromMSInstall" Value="&quot;net start [SERVICENAME]&quot;"
            After="CostFinalize" />
    <CustomAction Id="StartWinServiceFromMSInstall" BinaryKey="WixCA" DllEntry="WixQuietExec"
            Execute="deferred" Return="ignore" Impersonate="yes" />


    <InstallExecuteSequence>
	  <!-- have tested with
	   <DeleteServices><![CDATA[(CDATA[REMOVE ~= "ALL" AND NOT WIX_UPGRADE_DETECTED)]]></DeleteServices>
	  <DeleteServices><![CDATA[REMOVE ~= "ALL" AND (NOT UPGRADINGPRODUCTCODE)]]> </DeleteServices>
	  <InstallServices><![CDATA[NOT Installed]]> </InstallServices>
           -->
      <Custom Action="StartWinServiceFromMSInstall" Before="InstallFinalize">
        <![CDATA[((NOT INSTALLED) AND (ASSERVICE ~= "true"))]]>
      </Custom>
    </InstallExecuteSequence>
  </Product>

 
  <Fragment>
    <DirectoryRef Id="INSTALLFOLDER">

      <Component Id="ExecFileComponent" Guid="{6D7A2CD7-33CA-4EC9-B102-1831FF83224F}">
        <File Id="MSExe" Source="$(var.HarvestPath)\ServiceDataStandalone.exe" KeyPath="yes" />
      </Component>
    </DirectoryRef>

    <Component Id="ServiceInstall" Guid="{32D2D2BD-37B9-454E-A565-FE1294AAB988}" Directory="INSTALLFOLDER">
      <File Id="MSServiceExe" Source="$(var.HarvestPath)\ServiceData.exe" KeyPath="yes" />
      <Condition><![CDATA[ASSERVICE ~= "true"]]></Condition>
      <ServiceInstall Id="ServiceInstallation"
                      DisplayName="[SERVICENAME]"
                      Name="[SERVICENAME]"
                      ErrorControl="normal"
                      Start="auto"
                      Interactive="no"
                      Description="ServiceData service"
                      Type="ownProcess"
                      Vital="yes"
                      Account="[SERVICEACCOUNT]"
                      Password="[SERVICEPASSWORD]">
        <util:PermissionEx
          User="Everyone"
          GenericAll="yes"
          ServiceChangeConfig="yes"
          ServiceEnumerateDependents="yes"
          ChangePermission="yes"
          ServiceInterrogate="yes"
          ServicePauseContinue="no"
          ServiceQueryConfig="yes"
          ServiceQueryStatus="yes"
          ServiceStart="yes"
          ServiceStop="yes" />
      </ServiceInstall>
      <ServiceControl Id="ServiceControl" Name="[SERVICENAME]" Stop="both" Remove="uninstall" Start="install"  Wait="no" />
    </Component>
  </Fragment>

  <Fragment>
    <ComponentGroup Id="ProductComponents" Directory="INSTALLFOLDER">
	  <ComponentRef Id="ExecFileComponent" />
          <ComponentRef Id="ServiceInstall" />	  
    </ComponentGroup>
  </Fragment>
</Wix>

[nikryden]

I found what was wrong, It was setting the ASSERVICE = false always when doing update, I save this value to the register and send ASSERVICE = empty and now does it work. I also add the DeleteServices to the InstallExecuteSequence

<InstallServices><![CDATA[NOT Installed]]></InstallServices>
<DeleteServices><![CDATA[(REMOVE ~= "ALL" AND (NOT UPGRADINGPRODUCTCODE))]]></DeleteServices>