Skip to content
/ wix Public

Commit 405b907

Browse files
committed
Require "accept EULA" in .nupkgs plus some "accept EULA" bug fixes
Resolves 9196
1 parent a389a98 commit 405b907

File tree

39 files changed

+117
-12
lines changed

39 files changed

+117
-12
lines changed

src/Directory.Build.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141

4242
<PackageEulaSource>$(RootFolder)OSMFEULA.txt</PackageEulaSource>
4343
<PackageLicenseFile>OSMFEULA.txt</PackageLicenseFile>
44+
<PackageLicenseAcceptanceTargets>$(MSBuildThisFileDirectory)internal\targets\CheckLicenseAcceptance.targets</PackageLicenseAcceptanceTargets>
4445
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
4546

4647
<Product Condition=" '$(WixOfficialBuild)'!='true' ">WiX Dev Build</Product>

src/Directory.Build.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
<NuspecProperties>$(NuspecProperties);Copyright=$(Copyright);Description=$(Description);Title=$(Title)</NuspecProperties>
4949
<NuspecProperties>$(NuspecProperties);RepositoryType=$(RepositoryType);RepositoryCommit=$(RepositoryCommit);RepositoryUrl=$(RepositoryUrl)</NuspecProperties>
5050
<NuspecProperties>$(NuspecProperties);PackageTags=$(PackageTags)</NuspecProperties>
51-
<NuspecProperties>$(NuspecProperties);ProjectUrl=$(ProjectUrl);ProjectFolder=$(MSBuildProjectDirectory);RootFolder=$(RootFolder);EulaTxt=$(PackageEulaSource);IconPng=$(PackageIconSource)</NuspecProperties>
51+
<NuspecProperties>$(NuspecProperties);ProjectUrl=$(ProjectUrl);ProjectFolder=$(MSBuildProjectDirectory);RootFolder=$(RootFolder);EulaTxt=$(PackageEulaSource);IconPng=$(PackageIconSource);LicenseAcceptanceTargets=$(PackageLicenseAcceptanceTargets)</NuspecProperties>
5252
</PropertyGroup>
5353
</Target>
5454

src/Directory.csproj.props

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@
1111
<DebugType Condition=" '$(DebugType)'=='' ">embedded</DebugType>
1212
</PropertyGroup>
1313

14-
<ItemGroup Condition=" '$(IsWixTestProject)'!='true' ">
15-
<Content Include="$(PackageEulaSource)" Pack="true" PackagePath="/" />
16-
<Content Include="$(PackageIconSource)" Pack="true" PackagePath="/" />
17-
</ItemGroup>
14+
<PropertyGroup>
15+
<AcceptEula>abc;wix7;xyz;123</AcceptEula>
16+
</PropertyGroup>
1817
</Project>

src/Directory.csproj.targets

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,19 @@
1313
<SignOutput>false</SignOutput>
1414
</PropertyGroup>
1515

16-
1716
<PropertyGroup Condition=" '$(IsWixMSTestProject)' == 'true' ">
1817
<!-- Force a .NET v6-compatible package. -->
1918
<MicrosoftTestingExtensionsCodeCoverageVersion>17.11.5</MicrosoftTestingExtensionsCodeCoverageVersion>
2019
<TestingPlatformShowTestsFailure>true</TestingPlatformShowTestsFailure>
2120
</PropertyGroup>
2221

22+
<ItemGroup Condition=" '$(IsWixTestProject)'!='true' ">
23+
<Content Include="$(PackageEulaSource)" Pack="true" PackagePath="/" />
24+
<Content Include="$(PackageIconSource)" Pack="true" PackagePath="/" />
25+
<Content Include="$(PackageLicenseAcceptanceTargets)" Pack="true" PackagePath="build/$(MSBuildProjectName).targets"
26+
Condition=" '$(IsWixExtension)' != 'true' " />
27+
</ItemGroup>
28+
2329
<ItemGroup Condition=" '$(IsWixTestProject)'=='true' ">
2430
<PackageReference Include="Microsoft.NET.Test.Sdk" />
2531
<PackageReference Include="xunit" />

src/api/burn/WixToolset.BootstrapperApplicationApi/WixToolset.BootstrapperApplicationApi.nuspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
<file src="$projectFolder$\README.md" />
3030

3131
<file src="$projectFolder$\build\WixToolset.BootstrapperApplicationApi.props" target="build\" />
32+
<file src="$licenseAcceptanceTargets$" target="build\$id$.targets" />
3233

3334
<file src="$projectFolder$\build\_._" target="lib\native" />
3435
<file src="net462\$id$.dll" target="lib\net462" />

src/api/burn/bextutil/bextutil.nuspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
<file src="$iconPng$" />
2525
<file src="$projectFolder$\README.md" />
2626
<file src="$projectFolder$\build\$id$.props" target="build\" />
27+
<file src="$licenseAcceptanceTargets$" target="build\$id$.targets" />
2728
<file src="$projectFolder$\inc\*" target="build\native\include" />
2829
<file src="$projectFolder$\..\inc\BootstrapperExtensionTypes.h" target="build\native\include" />
2930
<file src="$projectFolder$\..\inc\BootstrapperExtensionEngineTypes.h" target="build\native\include" />

src/dtf/WixToolset.Dtf.CustomAction/WixToolset.Dtf.CustomAction.nuspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
<file src="$iconPng$" />
2525
<file src="$projectFolder$\README.md" />
2626
<file src="$projectFolder$\$id$.targets" target="build" />
27+
<file src="$licenseAcceptanceTargets$" target="build" />
2728
<file src="net472\WixToolset.Dtf.MakeSfxCA.exe" target="tools" />
2829
<file src="net472\WixToolset.Dtf.MakeSfxCA.exe.config" target="tools" />
2930
<file src="net472\WixToolset.Dtf.Compression.dll" target="tools" />

src/dtf/WixToolset.Dtf.CustomAction/WixToolset.Dtf.CustomAction.targets

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
<Import Project="$(CustomBeforeWixCATargets)" Condition=" '$(CustomBeforeWixCATargets)' != '' and Exists('$(CustomBeforeWixCATargets)')" />
77

8+
<Import Project="CheckLicenseAcceptance.targets" />
9+
810
<PropertyGroup>
911
<WixCATargetsImported>true</WixCATargetsImported>
1012

src/ext/Bal/wixext-backward-compatible/WixToolset.Bal.wixext.nuspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
<file src="$iconPng$" />
2222
<file src="$projectFolder$\README.md" />
2323
<file src="$projectFolder$\WixToolset.Bal.wixext.targets" target="build" />
24+
<file src="$licenseAcceptanceTargets$" target="build" />
2425
<file src="WixToolset.BootstrapperApplications.wixext.dll" target="$wixExtensionPackageFolder$" />
2526
</files>
2627
</package>

src/ext/Bal/wixext-backward-compatible/WixToolset.Bal.wixext.targets

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,6 @@
88
<UnsupportedWixExtension Include="WixToolset.BootstrapperApplications.wixext"
99
Condition=" !Exists('$(MSBuildThisFileDirectory)..\$(WixToolsetExtensionPackageFolder)\WixToolset.BootstrapperApplications.wixext.dll') " />
1010
</ItemGroup>
11+
12+
<Import Project="CheckLicenseAcceptance.targets" />
1113
</Project>

0 commit comments

Comments
 (0)