Skip to content
/ wix Public

Commit 7760a8b

Browse files
committed
Refine comments and documentation for ProductSearch type="exists"
1 parent 5607281 commit 7760a8b

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/burn/engine/search.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1252,7 +1252,8 @@ static HRESULT MsiProductSearch(
12521252
hr = BVariantChangeType(&value, type);
12531253
ExitOnFailure(hr, "Failed to change value type.");
12541254

1255-
// Alter value here after value has changed to numberic type.
1255+
// When testing if a product exists, replace the value with a numeric "true" or "false"
1256+
// based on the calculated install state.
12561257
if (BURN_MSI_PRODUCT_SEARCH_TYPE_EXISTS == pSearch->MsiProductSearch.Type)
12571258
{
12581259
value.llValue = (value.llValue == INSTALLSTATE_ABSENT) ? 0 : 1;

src/xsd/util.xsd

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1346,7 +1346,10 @@
13461346
</xs:enumeration>
13471347
<xs:enumeration value="exists">
13481348
<xs:annotation>
1349-
<xs:documentation>Saves true if a matching product entry is found; false otherwise.</xs:documentation>
1349+
<xs:documentation>
1350+
[WiX v7 and later]
1351+
Saves true if a matching product entry is found (non-absent); false otherwise.
1352+
</xs:documentation>
13501353
</xs:annotation>
13511354
</xs:enumeration>
13521355
</xs:restriction>

0 commit comments

Comments
 (0)