Skip to content

Conversation

@robmen
Copy link
Member

@robmen robmen commented Jan 3, 2026

A couple of fixes rebased into @charles-juicelabs original PR 573:

We develop an application with a DLL that is loaded into many processes, largely outside of our control. It is confusing for our users when they are prompted to close these seemingly unrelated applications when we update the DLL. Updating the DLL requires a reboot independently of any files being in use anyway, so hiding the "Files In Use" dialog is a nice solution for us.

There are other examples of people wanting to disable the "Files In Use" dialog:

Add bal:DisplayFilesInUseDialogCondition, similar to bal::DisplayInternalUICondition, to be added to MsiPackage elements to control the display of "Files In Use" in WixStandardBoostrapperApplication.

For example:

<Bundle Name="...">
  <!-- ... -->
  <Chain>
    <MsiPackage 
      Id="..."
      SourceFile="..."
      bal:DisplayFilesInUseDialogCondition="no"
    />
  </Chain>
</Bundle>

Fixes wixtoolset/issues#8807.
Closes #573 (could not update source branch)

@robmen robmen enabled auto-merge (rebase) January 3, 2026 00:30
@robmen robmen requested a review from barnson January 3, 2026 00:31
@robmen
Copy link
Member Author

robmen commented Jan 3, 2026

@barnson I reviewed everything but added doc, so could you review bal.xsd?

@robmen robmen requested a review from barnson January 3, 2026 06:53
@robmen robmen force-pushed the robmen/add-display-files-in-use-dialog-attribute branch from cd46cf0 to fddc536 Compare January 3, 2026 06:54
Disabling display skips showing the "Files In Use" dialog and returning
a result as if the user had chosen to ignore the dialog and reboot in
the case of files that were unable to be replaced.
@robmen robmen force-pushed the robmen/add-display-files-in-use-dialog-attribute branch from fddc536 to 07e4d88 Compare January 3, 2026 07:40
@robmen robmen merged commit 8ebde13 into main Jan 3, 2026
2 checks passed
@robmen robmen deleted the robmen/add-display-files-in-use-dialog-attribute branch January 3, 2026 14:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide "Files In Use" dialog behaving as if ignore was chosen

4 participants