Avoid use of PyObject_DelAttr{,String} in Python 3.12 SABI builds
#1225
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjakob
reviewed
Nov 24, 2025
src/common.cpp
Outdated
| } | ||
|
|
||
| void delattr(PyObject *obj, const char *key) { | ||
| #if (defined(Py_LIMITED_API) && PY_LIMITED_API < 0x030D0000) |
Owner
There was a problem hiding this comment.
I don't think we need the parens around the preprocessor expression (and this pattern generally isn't used in the codebase)
Contributor
Author
There was a problem hiding this comment.
Ah, sorry about that. I copied this directly from another such statement in the same file, so it's at least used that way in src/common.cpp.
(EDIT: I copied part of a ternary statement, that's my bad. Fixed in the latest revision.)
…n 3.12 SABI builds
`PyObject_DelAttr{,String}` are part of the stable ABI starting only from Python 3.13.
Thus, when building extensions targeting the stable ABI for Python 3.12, we should fall
back to the earlier `PyObject_SetAttr{,String}(obj, key, NULL)` pattern.
nicholasjng
force-pushed
the
stable-abi-fixes-312
branch
from
7c01405 to
74fce09
Compare
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyObject_DelAttr{,String}are part of the stable ABI starting only from Python 3.13. Thus, when building extensions targeting the stable ABI for Python 3.12, we should fall back to the earlierPyObject_SetAttr{,String}(obj, key, NULL)pattern.This should fix the
abi3auditfailures I observed in nicholasjng/nanobind-bazel#83.The implementation idea is based on the second paragraph of the https://docs.python.org/3/c-api/object.html#c.PyObject_SetAttrString doc.