Skip to content

Avoid use of PyObject_DelAttr{,String} in Python 3.12 SABI builds #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2025
Merged

Avoid use of PyObject_DelAttr{,String} in Python 3.12 SABI builds #1225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,13 +451,23 @@ void setattr(PyObject *obj, PyObject *key, PyObject *value) {
}

void delattr(PyObject *obj, const char *key) {
#if defined(Py_LIMITED_API) && PY_LIMITED_API < 0x030D0000
int rv = PyObject_SetAttrString(obj, key, nullptr);
#else
int rv = PyObject_DelAttrString(obj, key);
#endif

if (rv)
raise_python_error();
}

void delattr(PyObject *obj, PyObject *key) {
#if defined(Py_LIMITED_API) && PY_LIMITED_API < 0x030D0000
int rv = PyObject_SetAttr(obj, key, nullptr);
#else
int rv = PyObject_DelAttr(obj, key);
#endif

if (rv)
raise_python_error();
}
Expand Down
Loading