-
Notifications
You must be signed in to change notification settings - Fork 7
more robust resolv.conf check #53
Copy link
Copy link
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershealthrelated to the health check, either memory or networkrelated to the health check, either memory or network
Description
Activity
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershealthrelated to the health check, either memory or networkrelated to the health check, either memory or network
As the comment below mentions, in order to check the
resolv.conffor different namespaces, we have to look into the/etc/namespace/../dir for that version ofresolv.conf.coredns-healthcheck/pkg/engine/engine.go
Lines 175 to 177 in 468a6f2
Currently only the one that version of resolv.conf is checked that is shared across all network namespaces. Those net ns that have their own versions are not checked.
coredns-healthcheck/pkg/netns/remedy.go
Lines 24 to 27 in 468a6f2
We can do that in the remedy.go file, keeping in mind that we already have the namespace information (as a
netnsobject).