Merge pull request #51 from wjdp/fix/49

wjdp · web-flow · commit 01148bba8750 · 2017-08-05T21:43:41.000+01:00
Update TLS conf to actually disable H2
diff --git a/htmltest/check-link_test.go b/htmltest/check-link_test.go
@@ -128,6 +128,14 @@ func TestAnchorExternalHTTPSInvalid(t *testing.T) {
 	tExpectIssueCount(t, hT, 6)
 }
 
+func TestAnchorExternalHTTPSBadH2(t *testing.T) {
+	// should connect to servers with bad http/2 support
+	// See issue #49
+	tSkipShortExternal(t)
+	hT := tTestFile("fixtures/links/https-valid-h2.html")
+	tExpectIssueCount(t, hT, 0)
+}
+
 func TestAnchorExternalMissingProtocolValid(t *testing.T) {
 	// works for valid links missing the protocol
 	tSkipShortExternal(t)
diff --git a/htmltest/fixtures/links/https-valid-h2.html b/htmltest/fixtures/links/https-valid-h2.html
@@ -0,0 +1,11 @@
+<html>
+
+<body>
+    <a href="https://f5.com/">F5, the people who make BIG/IP, which can't do HTTP/2 very well</a>
+    <a href="https://www.southampton.ac.uk/">Southampton Uni, who use BIG/IP and therefore cannot do HTTP/2 very well</a>
+    <a href="https://www.southampton.ac.uk/">Southampton Uni, who use BIG/IP and therefore cannot do HTTP/2 very well</a>
+
+    <a href="https://www.linkedin.com/">LinkedIn does not seem to support APLN.</a>
+</body>
+
+</html>
diff --git a/htmltest/htmltest.go b/htmltest/htmltest.go
@@ -11,6 +11,7 @@ import (
 	"path"
 	"sync"
 	"time"
+	"crypto/tls"
 )
 
 // HTMLTest struct, A html testing session, user options are passed in and
@@ -42,7 +43,12 @@ func Test(optsUser map[string]interface{}) *HTMLTest {
 		(hT.opts.LogSort == "seq"))
 
 	transport := &http.Transport{
-		TLSNextProto: nil, // Disable HTTP/2, "write on closed buffer" errors
+		// Disable HTTP/2, this is required due to a number of edge cases where http negotiates H2, but something goes
+		// wrong when actually using it. Downgrading to H1 when this issue is hit is not yet supported so we use the
+		// following to disable H2 support:
+		// > Programs that must disable HTTP/2 can do so by setting Transport.TLSNextProto ... to a non-nil, empty map.
+		// See issue #49
+		TLSNextProto: make(map[string]func(authority string, c *tls.Conn) http.RoundTripper),
 	}
 	hT.httpClient = &http.Client{
 		// Durations are in nanoseconds
