Add fallback to A/AAAA records if no MX records are found.

tomtom5152 · tomtom5152 · commit 7697c196f0df · 2017-08-20T16:08:45.000+01:00
As per https://tools.ietf.org/html/rfc5321#section-5 this should fallback to the hostname for that domain.
diff --git a/htmltest/check-link.go b/htmltest/check-link.go
@@ -348,33 +348,46 @@ func (hT *HTMLTest) checkMailto(ref *htmldoc.Reference) {
 		})
 		return
 	}
+
+	// split off domain, check mx, fallback to A or AAAA if that fais
 	domain := strings.Split(ref.URL.Opaque, "@")[1]
 	_, err := net.LookupMX(domain)
+	var dnserr *net.DNSError
+	var ok bool
 	if err != nil {
-		if dnserr, ok := err.(*net.DNSError); ok {
+		if dnserr, ok = err.(*net.DNSError); ok {
 			switch dnserr.Err {
 			case "no such host":
-				hT.issueStore.AddIssue(issues.Issue{
-					Level:     issues.LevelError,
-					Message:   "domain contains no valid MX records",
-					Reference: ref,
-				})
-				break
-			default:
-				hT.issueStore.AddIssue(issues.Issue{
-					Level:     issues.LevelError,
-					Message:   "unable to perform LookupMX, unkown error",
-					Reference: ref,
-				})
+				// current no MX records, but we should try again with A record
+				_, err := net.LookupHost(domain)
+				if dnserr, ok = err.(*net.DNSError); ok {
+					break
+				} else {
+					hT.issueStore.AddIssue(issues.Issue{
+						Level:     issues.LevelWarning,
+						Message:   "unable to perform LookupHost, unknown error",
+						Reference: ref,
+					})
+					return
+				}
 			}
 		} else {
 			hT.issueStore.AddIssue(issues.Issue{
 				Level:     issues.LevelWarning,
-				Message:   "unable to perform LookupMX, unkown error",
+				Message:   "unable to perform LookupMX, unknown error",
 				Reference: ref,
 			})
+			return
 		}
-		return
+	}
+
+	// check if we finally have a dnserr
+	if dnserr != nil {
+		hT.issueStore.AddIssue(issues.Issue{
+			Level:     issues.LevelError,
+			Message:   "email cannot be routed to domain, no MX/A/AAAA records",
+			Reference: ref,
+		})
 	}
 }
 
diff --git a/htmltest/check-link_test.go b/htmltest/check-link_test.go
@@ -376,11 +376,17 @@ func TestMailtoInvalidFormat(t *testing.T) {
 	tExpectIssue(t, hT, "contains an invalid email address", 1)
 }
 
-func TestMailtoInvalidMx(t *testing.T) {
+func TestMailtoInvalidNoRecords(t *testing.T) {
 	// fails for invalid mailto links
-	hT := tTestFile("fixtures/links/invalid_mailto_mx.html")
+	hT := tTestFile("fixtures/links/invalid_mailto_norecords.html")
 	tExpectIssueCount(t, hT, 1)
-	tExpectIssue(t, hT, "domain contains no valid MX records", 1)
+	tExpectIssue(t, hT, "email cannot be routed to domain, no MX/A/AAAA records", 1)
+}
+
+func TestMailtoInvalidAFallback(t *testing.T) {
+	// fails for invalid mailto links
+	hT := tTestFile("fixtures/links/invalid_mailto_fallback.html")
+	tExpectIssueCount(t, hT, 0)
 }
 
 func TestMailtoIgnore(t *testing.T) {
diff --git a/htmltest/fixtures/links/invalid_mailto_fallback.html b/htmltest/fixtures/links/invalid_mailto_fallback.html
@@ -0,0 +1,9 @@
+<html>
+
+<body>
+
+<a href="mailto:octocat@example.com">Meow me</a>
+
+</body>
+
+</html>
diff --git a/htmltest/fixtures/links/invalid_mailto_mx.html b/htmltest/fixtures/links/invalid_mailto_mx.html
diff --git a/htmltest/fixtures/links/invalid_mailto_norecords.html b/htmltest/fixtures/links/invalid_mailto_norecords.html
@@ -0,0 +1,9 @@
+<html>
+
+<body>
+
+<a href="mailto:octocat@fail.test">Meow me</a>
+
+</body>
+
+</html>

-Original file line number
+Diff line change
@@ @@ -0,0 +1,9 @@ @@
 +<html>
++
 +<body>
++
 +<a href="mailto:[email protected]">Meow me</a>
++
 +</body>
++
 +</html>