Fix IOS task queue race condition issue when sending massive requests

Fix #72 status code except 2xx will now causing a promise rejection

Author: wkh237

src/ios/RNFetchBlobFS.m

@@ -207,7 +207,6 @@ + (NSNumber *) writeFileFromFile:(NSString *)src toFile:(NSString *)dest append:
 
 + (void) writeFile:(NSString *)path encoding:(NSString *)encoding data:(NSString *)data append:(BOOL)append resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject
 {
-    NSLog(encoding);
     @try {
         NSFileManager * fm = [NSFileManager defaultManager];
         NSError * err = nil;

src/ios/RNFetchBlobNetwork.m

@@ -23,17 +23,19 @@
 //
 ////////////////////////////////////////
 
-NSMutableDictionary * taskTable;
+NSMapTable * taskTable;
 NSMutableDictionary * progressTable;
 NSMutableDictionary * uploadProgressTable;
 
+
 @interface RNFetchBlobNetwork ()
 {
     BOOL * respFile;
     NSString * destPath;
     NSOutputStream * writeStream;
     long bodyLength;
     NSMutableDictionary * respInfo;
+    NSInteger respStatus;
 }
 
 @end
@@ -61,7 +63,7 @@ - (id)init {
         taskQueue.maxConcurrentOperationCount = 10;
     }
     if(taskTable == nil) {
-        taskTable = [[NSMutableDictionary alloc] init];
+        taskTable = [[NSMapTable alloc] init];
     }
     if(progressTable == nil)
     {
@@ -139,6 +141,7 @@ - (void) sendRequest:(__weak NSDictionary  * _Nullable )options
     {
         defaultConfigObject.timeoutIntervalForRequest = [[options valueForKey:@"timeout"] floatValue]/1000;
     }
+    defaultConfigObject.HTTPMaximumConnectionsPerHost = 10;
     session = [NSURLSession sessionWithConfiguration:defaultConfigObject delegate:self delegateQueue:taskQueue];
     if(path != nil || [self.options valueForKey:CONFIG_USE_TEMP]!= nil)
     {
@@ -193,6 +196,7 @@ - (void) URLSession:(NSURLSession *)session dataTask:(NSURLSessionDataTask *)dat
 
     NSHTTPURLResponse *httpResponse = (NSHTTPURLResponse*)response;
     NSInteger statusCode = [(NSHTTPURLResponse *)response statusCode];
+    respStatus = statusCode;
     if ([response respondsToSelector:@selector(allHeaderFields)])
     {
         NSDictionary *headers = [httpResponse allHeaderFields];
@@ -242,7 +246,7 @@ - (void) URLSession:(NSURLSession *)session dataTask:(NSURLSessionDataTask *)dat
                      @"respType" : respType,
                      @"timeout" : @NO,
                      @"status": [NSString stringWithFormat:@"%d", statusCode ]
-                     };
+                    };
 
         [self.bridge.eventDispatcher
          sendDeviceEventWithName: EVENT_STATE_CHANGE
@@ -270,6 +274,7 @@ - (void) URLSession:(NSURLSession *)session dataTask:(NSURLSessionDataTask *)dat
             NSLog(@"write file error");
         }
     }
+    
     completionHandler(NSURLSessionResponseAllow);
 }
 
@@ -312,42 +317,66 @@ - (void) URLSession:(NSURLSession *)session task:(NSURLSessionTask *)task didCom
 {
 
     self.error = error;
-    [[UIApplication sharedApplication] setNetworkActivityIndicatorVisible:NO];
-    
+    NSString * errMsg = [NSNull null];
+    NSString * respStr = [NSNull null];
     NSString * respType = [respInfo valueForKey:@"respType"];
-    if(error != nil) {
-        NSLog([error localizedDescription]);
+    
+    [[UIApplication sharedApplication] setNetworkActivityIndicatorVisible:NO];
+    if(error != nil)
+    {
+        errMsg = [error localizedDescription];
+    }
+    if(respInfo == nil)
+    {
+        respInfo = [NSNull null];
     }
 
-    if(respFile == YES)
+    // Fix #72 response with status code 200 ~ 299 considered as success
+    if(respStatus> 299 || respStatus < 200)
+    {
+        errMsg = [NSString stringWithFormat:@"Request failed, status %d", respStatus];
+    }
+    else
     {
-        [writeStream close];
-        callback(@[error == nil ? [NSNull null] : [error localizedDescription],
-                   respInfo == nil ? [NSNull null] : respInfo,
-                   destPath
-                ]);
+        if(respFile == YES)
+        {
+            [writeStream close];
+            respStr = destPath;
+        }
+        // base64 response
+        else {
+            // #73 fix unicode data encoding issue :
+            // when response type is BASE64, we should first try to encode the response data to UTF8 format
+            // if it turns out not to be `nil` that means the response data contains valid UTF8 string,
+            // in order to properly encode the UTF8 string, use URL encoding before BASE64 encoding.
+            NSString * urlEncoded = [[[NSString alloc] initWithData:respData encoding:NSUTF8StringEncoding]
+                                     stringByAddingPercentEncodingWithAllowedCharacters:[NSCharacterSet URLQueryAllowedCharacterSet]];
+            NSString * base64 = @"";
+            if(urlEncoded != nil)
+                base64 = [[urlEncoded dataUsingEncoding:NSUTF8StringEncoding] base64EncodedStringWithOptions:0];
+            else
+                base64 = [respData base64EncodedStringWithOptions:0];
+            respStr = base64;
+            
+        }
     }
-    // base64 response
-    else {
-        NSString * utf8 = [[[NSString alloc] initWithData:respData encoding:NSUTF8StringEncoding] stringByAddingPercentEncodingWithAllowedCharacters:[NSCharacterSet URLQueryAllowedCharacterSet]];
-        NSString * base64 = @"";
-        if(utf8 != nil)
-            base64 = [[utf8 dataUsingEncoding:NSUTF8StringEncoding] base64EncodedStringWithOptions:0];
+    
+    callback(@[ errMsg, respInfo, respStr ]);
+    
+    @synchronized(taskTable, uploadProgressTable, progressTable)
+    {
+        if([taskTable objectForKey:taskId] == nil)
+            NSLog(@"object released.");
         else
-            base64 = [respData base64EncodedStringWithOptions:0];
-        callback(@[error == nil ? [NSNull null] : [error localizedDescription],
-                   respInfo == nil ? [NSNull null] : respInfo,
-                   base64
-                ]);
-        
+            [taskTable removeObjectForKey:taskId];
+        [uploadProgressTable removeObjectForKey:taskId];
+        [progressTable removeObjectForKey:taskId];
     }
 
-    [taskTable removeObjectForKey:taskId];
-    [uploadProgressTable removeObjectForKey:taskId];
-    [progressTable removeObjectForKey:taskId];
     respData = nil;
     receivedBytes = 0;
     [session finishTasksAndInvalidate];
+
 }
 
 // upload progress handler