Skip to content

Commit 90334bd

Browse files
authored
Merge pull request opencontainers#303 from runcom/fix-297
Fixies to img: and schema:
2 parents e566f16 + 3795c5f commit 90334bd

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

img/media-types.dot

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,10 @@ digraph G {
33
manifestList [shape=note, label="Manifest list\n<<optional>>\napplication/vnd.oci.image.manifest.list.v1+json"]
44
manifest [shape=note, label="Image manifest\napplication/vnd.oci.image.manifest.v1+json"]
55
config [shape=note, label="Image JSON\napplication/vnd.oci.image.config.v1+json"]
6-
layer [shape=note, label="Layer tar+gzip\napplication/vnd.oci.image.layer.tar+gzip"]
6+
layer [shape=note, label="Layer tar+gzip\napplication/vnd.oci.image.layer.tar+gzip\napplication/vnd.oci.image.layer.nondistributable.tar+gzip"]
77
}
88

99
manifestList -> manifest [label="1..*"]
1010
manifest -> config [label="1..1"]
1111
manifest -> layer [label="1..*"]
12-
combined
1312
}

img/media-types.png

-67.4 KB
Loading

schema/manifest_test.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,17 +37,18 @@ func TestManifest(t *testing.T) {
3737
fail: true,
3838
},
3939

40-
// expected failure: config.size is integer, expected string
40+
// expected failure: config.size is a string, expected integer
4141
{
4242
manifest: `
4343
{
4444
"schemaVersion": 2,
4545
"mediaType": "application/vnd.oci.image.manifest.v1+json",
4646
"config": {
47-
"mediaType": "application/vnd.oci.image.serialization.v1+json",
47+
"mediaType": "application/vnd.oci.image.config.v1+json",
4848
"size": "1470",
4949
"digest": "sha256:c86f7763873b6c0aae22d963bab59b4f5debbed6685761b5951584f6efb0633b"
50-
}
50+
},
51+
"layers": []
5152
}
5253
`,
5354
fail: true,
@@ -60,14 +61,15 @@ func TestManifest(t *testing.T) {
6061
"schemaVersion": 2,
6162
"mediaType": "application/vnd.oci.image.manifest.v1+json",
6263
"config": {
63-
"mediaType": "application/vnd.oci.image.serialization.v1+json",
64+
"mediaType": "application/vnd.oci.image.config.v1+json",
6465
"size": 1470,
6566
"digest": "sha256:c86f7763873b6c0aae22d963bab59b4f5debbed6685761b5951584f6efb0633b"
6667
},
6768
"layers": [
6869
{
6970
"mediaType": "application/vnd.oci.image.layer.tar+gzip",
70-
"size": "675598"
71+
"size": "675598",
72+
"digest": "sha256:c86f7763873b6c0aae22d963bab59b4f5debbed6685761b5951584f6efb0633b"
7173
}
7274
]
7375
}
@@ -82,7 +84,7 @@ func TestManifest(t *testing.T) {
8284
"schemaVersion": 2,
8385
"mediaType": "application/vnd.oci.image.manifest.v1+json",
8486
"config": {
85-
"mediaType": "application/vnd.oci.image.serialization.v1+json",
87+
"mediaType": "application/vnd.oci.image.config.v1+json",
8688
"size": 1470,
8789
"digest": "sha256:c86f7763873b6c0aae22d963bab59b4f5debbed6685761b5951584f6efb0633b"
8890
},

0 commit comments

Comments
 (0)