You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
runtime: Move start's --id to a positional parameter
I added this as an option in 5033c59 (Add an --id option to 'start',
2015-09-15), because some callers might want to leave ID generation to
the runtime. When there is a long-running host process waiting on the
container process to perform cleanup, the runtime-caller may not need
to know the container ID. However, runC has been requiring a
user-specified ID since [1], and the coming create/start split will
follow the early-exit 'create' from [2], so require an ID here. We
can revisit this if we regain a long-running 'create' process.
You can create a config that adds no isolation vs. the runtime
namespace or completely joins another set of existing namespaces. It
seems odd to call that a new "container", but the ID is really more of
a process ID, and less of a container ID. The "container" phrasing is
just a useful hint that there might be some isolation going on. And
we're always creating a new "container process" with 'start' (which
will become 'create').
[1]: opencontainers/runc#541opencontainers/runc@a7278cad (Require container id as arg1,
2016-02-08, opencontainers/runc#541)
[2]: opencontainers/runc#827
Summary: Implement create and start
Signed-off-by: W. Trevor King <[email protected]>
0 commit comments