Skip to content

Commit f412693

Browse files
committed
.pullapprove.yml: List project maintainers separately
This repository is managed by the union of all OCI Project maintainers. To avoid having a few active maintainers from one project driving the template in ways that other projects don't support, require at least two approvals from each project. This will slow down acceptance a bit, but many maintainers belong to multiple projects (and their votes will count for each group [1]), so you won't need 12 separate maintainers voting to get a single project-template PR across the line. Also update from config format v1 to v2 [1,2]. [1]: http://docs.pullapprove.com/migrating-to-v2/ [2]: http://docs.pullapprove.com/ Signed-off-by: W. Trevor King <[email protected]>
1 parent eabcbd5 commit f412693

File tree

1 file changed

+35
-12
lines changed

1 file changed

+35
-12
lines changed

.pullapprove.yml

Lines changed: 35 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,36 @@
1-
approve_by_comment: true
2-
approve_regex: ^LGTM
3-
reject_regex: ^Rejected
4-
reset_on_push: true
5-
author_approval: ignored
6-
signed_off_by:
7-
required: true
8-
reviewers:
9-
teams:
10-
- tdc-maintainers
11-
- admins
12-
name: default
1+
version: 2
2+
3+
requirements:
4+
signed_off_by:
5+
required: true
6+
7+
group_defaults:
138
required: 2
9+
approve_by_comment:
10+
enabled: true
11+
approve_regex: ^LGTM
12+
reject_regex: ^Rejected
13+
reset_on_push:
14+
enabled: true
15+
author_approval:
16+
ignored: true
17+
18+
groups:
19+
image-spec:
20+
teams:
21+
- image-spec-maintainers
22+
image-tools:
23+
teams:
24+
- image-tools-maintainers
25+
go-digest:
26+
teams:
27+
- go-digest-maintainers
28+
runc:
29+
teams:
30+
- runc-maintainers
31+
runtime-spec:
32+
teams:
33+
- runtime-spec-maintainers
34+
runtime-tools:
35+
teams:
36+
- runtime-tools-maintainers

0 commit comments

Comments
 (0)