Skip to content

Commit 95e0d95

Browse files
committed
runtimetest: Make validateRlimits silent on Windows
This isn't a question of not being implemented yet. Windows does not, and is unlikely to ever, support rlimits [1]. And the spec only defines process.rlimits for POSIX platforms [2]. Folks writing Windows configs will only be setting process.rlimits as an out-of-spec extention. We, as runtime validators, are unlikely to write such configs. But if we use runtimetest in a container launched from such a config, we should silently ignore that out-of-spec extention, just like we silently ignore all other out-of-spec extentions, instead of logging a warning. [1]: opencontainers/runtime-spec#835 (comment) [2]: https://github.com/opencontainers/runtime-spec/blob/v1.0.0/config.md#posix-process Signed-off-by: W. Trevor King <[email protected]>
1 parent 502b569 commit 95e0d95

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

cmd/runtimetest/main.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -267,12 +267,11 @@ func validateHostname(spec *rspec.Spec) error {
267267
}
268268

269269
func validateRlimits(spec *rspec.Spec) error {
270-
if spec.Process == nil {
270+
if runtime.GOOS == "windows" {
271271
return nil
272272
}
273273

274-
if runtime.GOOS != "linux" && runtime.GOOS != "solaris" {
275-
logrus.Warnf("process.rlimits validation not yet implemented for OS %q", runtime.GOOS)
274+
if spec.Process == nil {
276275
return nil
277276
}
278277

0 commit comments

Comments
 (0)