Merge pull request #49 from ferdymercury/patch-1

apply clang-tidy modernize-use-override

Author: wlav

include/CPyCppyy/PyException.h

@@ -39,10 +39,10 @@ namespace CPyCppyy {
 class CPYCPPYY_CLASS_EXTERN PyException : public std::exception {
 public:
     PyException();
-    virtual ~PyException() noexcept;
+    ~PyException() noexcept override;
 
 // give reason for raised exception
-    virtual const char* what() const noexcept;
+    const char* what() const noexcept override;
 
 // clear Python error, to allow full error handling C++ side
     void clear() const noexcept;

src/CPPOverload.cxx

@@ -54,48 +54,48 @@ class TPythonCallback : public PyCallable {
         fCallable = callable;
     }
 
-    virtual ~TPythonCallback() {
+    ~TPythonCallback() override {
         Py_DECREF(fCallable);
         fCallable = nullptr;
     }
 
-    virtual PyObject* GetSignature(bool /*show_formalargs*/ = true) {
+    PyObject* GetSignature(bool /*show_formalargs*/ = true) override {
         return CPyCppyy_PyText_FromString("*args, **kwargs");
     }
-    virtual PyObject* GetPrototype(bool /*show_formalargs*/ = true) {
+    PyObject* GetPrototype(bool /*show_formalargs*/ = true) override {
         return CPyCppyy_PyText_FromString("<callback>");
     }
-    virtual PyObject* GetDocString() {
+    PyObject* GetDocString() override {
         if (PyObject_HasAttrString(fCallable, "__doc__")) {
             return PyObject_GetAttrString(fCallable, "__doc__");
         } else {
             return GetPrototype();
         }
     }
 
-    virtual int GetPriority() { return 100; };
-    virtual bool IsGreedy() { return false; };
+    int GetPriority() override { return 100; };
+    bool IsGreedy() override { return false; };
 
-    virtual int GetMaxArgs() { return 100; };
-    virtual PyObject* GetCoVarNames() { // TODO: pick these up from the callable
+    int GetMaxArgs() override { return 100; };
+    PyObject* GetCoVarNames() override { // TODO: pick these up from the callable
         Py_RETURN_NONE;
     }
-    virtual PyObject* GetArgDefault(int /* iarg */, bool /* silent */ =true) {
+    PyObject* GetArgDefault(int /* iarg */, bool /* silent */ =true) override {
         Py_RETURN_NONE;      // TODO: pick these up from the callable
     }
 
-    virtual PyObject* GetScopeProxy() { // should this be the module ??
+    PyObject* GetScopeProxy() override { // should this be the module ??
         Py_RETURN_NONE;
     }
 
-    virtual Cppyy::TCppFuncAddr_t GetFunctionAddress() {
+    Cppyy::TCppFuncAddr_t GetFunctionAddress() override {
         return (Cppyy::TCppFuncAddr_t)nullptr;
     }
 
-    virtual PyCallable* Clone() { return new TPythonCallback(*this); }
+    PyCallable* Clone() override { return new TPythonCallback(*this); }
 
-    virtual PyObject* Call(CPPInstance*& self,
-            CPyCppyy_PyArgs_t args, size_t nargsf, PyObject* kwds, CallContext* /* ctxt = 0 */) {
+    PyObject* Call(CPPInstance*& self,
+            CPyCppyy_PyArgs_t args, size_t nargsf, PyObject* kwds, CallContext* /* ctxt = 0 */) override {
 
 #if PY_VERSION_HEX >= 0x03080000
         if (self) {

src/Pythonize.cxx

@@ -237,8 +237,8 @@ struct CountedItemGetter : public ItemGetter {
 
 struct TupleItemGetter : public CountedItemGetter {
     using CountedItemGetter::CountedItemGetter;
-    virtual Py_ssize_t size() { return PyTuple_GET_SIZE(fPyObject); }
-    virtual PyObject* get() {
+    Py_ssize_t size() override { return PyTuple_GET_SIZE(fPyObject); }
+    PyObject* get() override {
         if (fCur < PyTuple_GET_SIZE(fPyObject)) {
             PyObject* item = PyTuple_GET_ITEM(fPyObject, fCur++);
             Py_INCREF(item);
@@ -251,8 +251,8 @@ struct TupleItemGetter : public CountedItemGetter {
 
 struct ListItemGetter : public CountedItemGetter {
     using CountedItemGetter::CountedItemGetter;
-    virtual Py_ssize_t size() { return PyList_GET_SIZE(fPyObject); }
-    virtual PyObject* get() {
+    Py_ssize_t size() override { return PyList_GET_SIZE(fPyObject); }
+    PyObject* get() override {
         if (fCur < PyList_GET_SIZE(fPyObject)) {
             PyObject* item = PyList_GET_ITEM(fPyObject, fCur++);
             Py_INCREF(item);
@@ -265,21 +265,21 @@ struct ListItemGetter : public CountedItemGetter {
 
 struct SequenceItemGetter : public CountedItemGetter {
     using CountedItemGetter::CountedItemGetter;
-    virtual Py_ssize_t size() {
+    Py_ssize_t size() override {
         Py_ssize_t sz = PySequence_Size(fPyObject);
         if (sz < 0) {
             PyErr_Clear();
             return PyObject_LengthHint(fPyObject, 8);
         }
         return sz;
     }
-    virtual PyObject* get() { return PySequence_GetItem(fPyObject, fCur++); }
+    PyObject* get() override { return PySequence_GetItem(fPyObject, fCur++); }
 };
 
 struct IterItemGetter : public ItemGetter {
     using ItemGetter::ItemGetter;
-    virtual Py_ssize_t size() { return PyObject_LengthHint(fPyObject, 8); }
-    virtual PyObject* get() { return (*(Py_TYPE(fPyObject)->tp_iternext))(fPyObject); }
+    Py_ssize_t size() override { return PyObject_LengthHint(fPyObject, 8); }
+    PyObject* get() override { return (*(Py_TYPE(fPyObject)->tp_iternext))(fPyObject); }
 };
 
 static ItemGetter* GetGetter(PyObject* args)