-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Open
Labels
bugneeds investigationThe bug has not yet been reproduced by me. Analysis or more details are needed.The bug has not yet been reproduced by me. Analysis or more details are needed.
Milestone
Description
Lines 24 to 38 in 53d6c4b
| //reject late packets belonging to previous frame (assuming 4 packets max. before push) | |
| if (e131SkipOutOfSequence && lastPushSeq) { | |
| int sn = p->sequenceNum & 0xF; | |
| if (sn) { | |
| if (lastPushSeq > 5) { | |
| if (sn > (lastPushSeq -5) && sn < lastPushSeq) return; | |
| } else { | |
| if (sn > (10 + lastPushSeq) || sn < lastPushSeq) return; | |
| } | |
| } | |
| } | |
| unsigned ddpChannelsPerLed = ((p->dataType & 0b00111000)>>3 == 0b011) ? 4 : 3; // data type 0x1B (formerly 0x1A) is RGBW (type 3, 8 bit/channel) | |
| uint32_t start = htonl(p->channelOffset) / ddpChannelsPerLed; |
We need to verify if the assumption stated in the source code - 4 packets max before push - is correct w.r.t to the protocol definitions, and analyze if packets that are more than 4 out-of-sequnce can lead to a corrupted LEDs display.
With HUB75 panels, users have succesfully streamed 64x64 pixels, so it seem that larger frame sizes generally do work.
Reference
#5390 (comment)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugneeds investigationThe bug has not yet been reproduced by me. Analysis or more details are needed.The bug has not yet been reproduced by me. Analysis or more details are needed.