Skip to content

Share API improvement ideas #315

@matheus23

Description

@matheus23

@appcypher and I had some ideas on how we could improve the share API.

Consider this a list of "may or may not be a good idea".

  • We should probably provide a (feature-gated) implementation of ExchangeKey. Feature-gated, because pulling in the RSA dependency may be undesired for WASM, where we might instead want to simply depend on WebCrypto (but in that case this needs re-thinking anyways, since that abstraction would require passing in an object from the JS side, not a static trait).
  • RsaError should probably be renamed to something more abstract when we add other protocols (e.g. Ed25519)
  • We should compute find_current_share_counter for the user (by default, at least). It can be made faster by caching previous results, but that doesn't mean the default case needs to be a more complicated API.
  • We probably don't need the Share struct. The share function is just fine. This struct was deleted.
  • Perhaps it's also possible to remove the receiver and sender modules, and simply merge them all into the share module.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions