Skip to content

Commit 4f233d5

Browse files
Implode - empty string bug - fix
1 parent 771aa2e commit 4f233d5

File tree

5 files changed

+13
-3
lines changed

5 files changed

+13
-3
lines changed

dist/1.x/string-utils-1.1.1.jar

5.58 KB
Binary file not shown.

pom-mavencentral.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
<groupId>io.github.wniemiec-util-java</groupId>
88
<artifactId>string-utils</artifactId>
9-
<version>1.1.0</version>
9+
<version>1.1.1</version>
1010
<name>StringUtils</name>
1111
<description>Contains methods that perform string manipulation.</description>
1212
<url>https://github.com/wniemiec-util-java/string-utils</url>

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
<groupId>wniemiec.util.java</groupId>
88
<artifactId>string-utils</artifactId>
9-
<version>1.1.0</version>
9+
<version>1.1.1</version>
1010
<name>StringUtils</name>
1111
<description>Contains methods that perform string manipulation.</description>
1212
<url>https://github.com/wniemiec-util-java/string-utils</url>

src/main/java/wniemiec/util/java/StringUtils.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,9 @@ public static <T> String implode(List<T> list, String delimiter) {
4444
response.append(delimiter);
4545
}
4646

47-
removeLastCharacter(response);
47+
if (!delimiter.isEmpty()) {
48+
removeLastCharacter(response);
49+
}
4850

4951
return response.toString();
5052
}

src/test/java/wniemiec/util/java/StringUtilsTest.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,14 @@ void testHelloWorld() {
1414

1515
Assertions.assertEquals("hello world", obtained);
1616
}
17+
18+
@Test
19+
void testHelloWorldEmptyDelimiter() {
20+
List<String> items = List.of("hello", "world");
21+
String obtained = StringUtils.implode(items, "");
22+
23+
Assertions.assertEquals("helloworld", obtained);
24+
}
1725

1826
@Test
1927
void testNullList() {

0 commit comments

Comments
 (0)