Report unimplemented registers using hex values; NB sometimes see "0x-1" -- signedness issue

rivimey · rivimey · commit d6f9b41f9ac3 · 2025-04-08T00:49:14.000+01:00
diff --git a/src/peripherals/peripheral.ts b/src/peripherals/peripheral.ts
@@ -34,15 +34,15 @@ export class BasePeripheral implements Peripheral {
   ) {}
 
   readUint32(offset: number) {
-    this.warn(`Unimplemented peripheral read from ${offset.toString(16)}`);
+    this.warn(`Unimplemented peripheral read from 0x${offset.toString(16)}`);
     if (offset > 0x1000) {
       this.warn('Unimplemented read from peripheral in the atomic operation region');
     }
     return 0xffffffff;
   }
 
   writeUint32(offset: number, value: number) {
-    this.warn(`Unimplemented peripheral write to ${offset.toString(16)}: ${value}`);
+    this.warn(`Unimplemented peripheral write to 0x${offset.toString(16)}: 0x${value.toString(16)}`);
   }
 
   writeUint32Atomic(offset: number, value: number, atomicType: number) {

Original file line number	Diff line number	Diff line change
`@@ -34,15 +34,15 @@ export class BasePeripheral implements Peripheral {`
`34`	`34`	`) {}`
`35`	`35`
`36`	`36`	`readUint32(offset: number) {`
`37`		- this.warn(`Unimplemented peripheral read from ${offset.toString(16)}`);
	`37`	+ this.warn(`Unimplemented peripheral read from 0x${offset.toString(16)}`);
`38`	`38`	`if (offset > 0x1000) {`
`39`	`39`	`this.warn('Unimplemented read from peripheral in the atomic operation region');`
`40`	`40`	`}`
`41`	`41`	`return 0xffffffff;`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`writeUint32(offset: number, value: number) {`
`45`		- this.warn(`Unimplemented peripheral write to ${offset.toString(16)}: ${value}`);
	`45`	+ this.warn(`Unimplemented peripheral write to 0x${offset.toString(16)}: 0x${value.toString(16)}`);
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`writeUint32Atomic(offset: number, value: number, atomicType: number) {`