Fixes for buffers when testing with Intel QAT hardware and fsanitize=address:

dgarske · dgarske · commit d472e15172b4 · 2022-06-01T10:52:05.000-07:00
* Fix for DH trim of leading zeros to use memmove.
diff --git a/wolfcrypt/src/port/intel/quickassist.c b/wolfcrypt/src/port/intel/quickassist.c
@@ -4246,7 +4246,7 @@ static void IntelQaDhAgreeCallback(void *pCallbackTag, CpaStatus status,
 
         /* return data and trim leading zeros */
         if (dev->qat.out && (dev->qat.out != pOut->pData || idxTrim > 0)) {
-            XMEMCPY(dev->qat.out, &out[idxTrim], pOut->dataLenInBytes);
+            XMEMMOVE(dev->qat.out, &out[idxTrim], pOut->dataLenInBytes);
         }
 
         /* return final length */

Original file line number	Diff line number	Diff line change
`@@ -4246,7 +4246,7 @@ static void IntelQaDhAgreeCallback(void *pCallbackTag, CpaStatus status,`
`4246`	`4246`
`4247`	`4247`	`/* return data and trim leading zeros */`
`4248`	`4248`	`if (dev->qat.out && (dev->qat.out != pOut->pData \|\| idxTrim > 0)) {`
`4249`		`- XMEMCPY(dev->qat.out, &out[idxTrim], pOut->dataLenInBytes);`
	`4249`	`+ XMEMMOVE(dev->qat.out, &out[idxTrim], pOut->dataLenInBytes);`
`4250`	`4250`	`}`
`4251`	`4251`
`4252`	`4252`	`/* return final length */`