Merge pull request #72 from douzzer/20231107-pthread_attr_destroy-unused-return

dgarske · web-flow · commit da533408c086 · 2023-11-08T21:03:40.000-08:00
20231107-pthread_attr_destroy-unused-return
diff --git a/wolfcrypt/src/async.c b/wolfcrypt/src/async.c
@@ -952,7 +952,9 @@ int wc_AsyncThreadCreate_ex(pthread_t *thread,
 exit_fail:
 
     fprintf(stderr, "AsyncThreadCreate error: %d\n", status);
-    (void)pthread_attr_destroy(&attr);
+    status = pthread_attr_destroy(&attr);
+    if (status != 0)
+        fprintf(stderr, "AsyncThreadCreate cleanup error: %d\n", status);
     return ASYNC_OP_E;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -952,7 +952,9 @@ int wc_AsyncThreadCreate_ex(pthread_t *thread,`
`952`	`952`	`exit_fail:`
`953`	`953`
`954`	`954`	`fprintf(stderr, "AsyncThreadCreate error: %d\n", status);`
`955`		`- (void)pthread_attr_destroy(&attr);`
	`955`	`+ status = pthread_attr_destroy(&attr);`
	`956`	`+ if (status != 0)`
	`957`	`+ fprintf(stderr, "AsyncThreadCreate cleanup error: %d\n", status);`
`956`	`958`	`return ASYNC_OP_E;`
`957`	`959`	`}`
`958`	`960`