Skip to content

Commit 1b9ec09

Browse files
rizlikdanielinux
authored andcommitted
fix reviewer's comments
1 parent 16c1601 commit 1b9ec09

File tree

4 files changed

+8
-10
lines changed

4 files changed

+8
-10
lines changed

hal/hal.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -189,8 +189,6 @@ int hal_flash_test_dualbank(void)
189189
uint8_t cur_fill = 0xb0;
190190
uint8_t new_fill = 0xf0;
191191
uint8_t fill;
192-
uint32_t bankA = TEST_ADDRESS_BANKA;
193-
uint32_t bankB = TEST_ADDRESS_BANKB;
194192
uint32_t pagePtr;
195193

196194
wolfBoot_printf("swap flash test at 0x%x\n", TEST_ADDRESS);
@@ -219,21 +217,21 @@ int hal_flash_test_dualbank(void)
219217
}
220218

221219
if (*((uint8_t*)(TEST_ADDRESS_BANKA)) != cur_fill) {
222-
wolfBoot_printf("Bank A data mismatch: %x != %x\n", bankA[0], cur_fill);
220+
wolfBoot_printf("Bank A data mismatch: %x != %x\n", *((uint8_t*)TEST_ADDRESS_BANKA), cur_fill);
223221
return -1;
224222
}
225223
if (*((uint8_t*)(TEST_ADDRESS_BANKB)) != new_fill) {
226-
wolfBoot_printf("Bank B data mismatch: %x != %x\n", bankB[0], new_fill);
224+
wolfBoot_printf("Bank B data mismatch: %x != %x\n", *((uint8_t*)TEST_ADDRESS_BANKB), new_fill);
227225
return -1;
228226
}
229227
hal_flash_dualbank_swap();
230228

231229
if (*((uint8_t*)(TEST_ADDRESS_BANKA)) != new_fill) {
232-
wolfBoot_printf("Bank A data mismatch after swap: %x != %x\n", bankA[0], new_fill);
230+
wolfBoot_printf("Bank A data mismatch after swap: %x != %x\n", *((uint8_t*)TEST_ADDRESS_BANKA), new_fill);
233231
return -1;
234232
}
235233
if (*((uint8_t*)(TEST_ADDRESS_BANKB)) != cur_fill) {
236-
wolfBoot_printf("Bank B data mismatch after swap: %x != %x\n", bankB[0], cur_fill);
234+
wolfBoot_printf("Bank B data mismatch after swap: %x != %x\n", *((uint8_t*)TEST_ADDRESS_BANKB), cur_fill);
237235
return -1;
238236
}
239237

hal/pic32ck.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ void hal_flash_dualbank_swap(void)
5252
void hal_init(void)
5353
{
5454
#if defined(TEST_CLOCK)
55-
/* toogle led at 1hz for 10sec */
55+
/* toggle led at 1hz for 10sec */
5656
pic32_clock_test(48000000U);
5757
#endif
5858
pic32_clock_fracdiv0_set(0, 0);
@@ -63,7 +63,7 @@ void hal_init(void)
6363
while (1) {}
6464
#endif
6565
#if defined(TEST_CLOCK)
66-
/* toogle led at 1hz */
66+
/* toggle led at 1hz */
6767
pic32_clock_test(120000000U);
6868
pic32_clock_reset();
6969
pic32_clock_test(48000000U);

hal/pic32ck_registers.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,4 @@
2727
#define GCLK_BASE (0x44010000U)
2828
#define MCLK_BASE (0x44012000U)
2929

30-
#endif /* PIC32CZ_REGISTERS_H */
30+
#endif /* PIC32CK_REGISTERS_H */

test-app/app_pic32ck.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* app_pic32cz.c
1+
/* app_pic32ck.c
22
*
33
* Test bare-metal boot-led-on application
44
*

0 commit comments

Comments
 (0)