Skip to content

Commit 71f2424

Browse files
committed
Reviewers requests
- Removed stray printfs from elf.c - Updated test-configs.yml to include build tests for config files
1 parent c841113 commit 71f2424

File tree

2 files changed

+20
-2
lines changed

2 files changed

+20
-2
lines changed

.github/workflows/test-configs.yml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,24 @@ jobs:
220220
config-file: ./config/examples/sim.config
221221
make-args: CFLAGS_EXTRA=-DWOLFBOOT_FLASH_MULTI_SECTOR_ERASE
222222

223+
sim_elf_scattered:
224+
uses: ./.github/workflows/test-build.yml
225+
with:
226+
arch: host
227+
config-file: ./config/examples/sim-elf-scattered.config
228+
229+
sim_elf_scattered_nobackup:
230+
uses: ./.github/workflows/test-build.yml
231+
with:
232+
arch: host
233+
config-file: ./config/examples/sim-elf-scattered.config
234+
make-args: DISABLE_BACKUP=1
235+
236+
sim32_elf_scattered:
237+
uses: ./.github/workflows/test-build.yml
238+
with:
239+
arch: host
240+
config-file: ./config/examples/sim32-elf-scattered.config
223241

224242
# TODO: SP math with small stack has issues
225243

src/elf.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ int elf_store_image_scattered(const unsigned char *hdr, unsigned long *entry_out
222222
paddr = (unsigned long)ph[i].paddr;
223223
offset = (unsigned long)ph[i].offset;
224224
filesz = (unsigned long)ph[i].file_size;
225-
printf("Writing section at address %lx offset %lx\n", paddr, offset);
225+
wolfBoot_printf("Writing section at address %lx offset %lx\n", paddr, offset);
226226
#ifdef EXT_FLASH
227227
if (ext_flash) {
228228
ext_flash_unlock();
@@ -261,7 +261,7 @@ int elf_store_image_scattered(const unsigned char *hdr, unsigned long *entry_out
261261
paddr = (unsigned long)ph[i].paddr;
262262
offset = (unsigned long)ph[i].offset;
263263
filesz = (unsigned long)ph[i].file_size;
264-
printf("Writing section at address %lx offset %lx\n", paddr, offset);
264+
wolfBoot_printf("Writing section at address %lx offset %lx\n", paddr, offset);
265265
#ifdef EXT_FLASH
266266
if (ext_flash) {
267267
ext_flash_unlock();

0 commit comments

Comments
 (0)