Reviewer requests: fix portability of "packed"

+ separate object for hal in otp-keystore-primer

Author: danielinux

include/otp_keystore.h

@@ -42,7 +42,14 @@
 
 #define OTP_HDR_SIZE 16
 
-struct __attribute__((packed)) wolfBoot_otp_hdr {
+#if (defined(__IAR_SYSTEMS_ICC__) && (__IAR_SYSTEMS_ICC__ > 8)) || \
+        defined(__GNUC__)
+    #define KEYSTORE_HDR_PACKED __attribute__((packed))
+#else
+    #define KEYSTORE_HDR_PACKED
+#endif
+
+struct KEYSTORE_HDR_PACKED wolfBoot_otp_hdr {
     char keystore_hdr_magic[8];
     uint16_t item_count;
     uint16_t flags;

tools/keytools/otp/Makefile

@@ -21,12 +21,12 @@ LDFLAGS+=$(CFLAGS) -T$(LSCRIPT) -lc -Wl,-Map=otp-keystore-primer.map
 ifeq ($(TARGET),stm32h7)
     CFLAGS+=-DTARGET_stm32h7
     CFLAGS+=-mcpu=cortex-m7 -ffunction-sections -fdata-sections -fno-common -ffreestanding -nostartfiles
-    PRI_KS_OBJS+=../../../hal/stm32h7.o
+    PRI_KS_OBJS+=stm32h7.o
 endif
 ifeq ($(TARGET),stm32h5)
     CFLAGS+=-DTARGET_stm32h5
     CFLAGS+=-mcpu=cortex-m33 -ffunction-sections -fdata-sections -fno-common -ffreestanding -nostartfiles
-    PRI_KS_OBJS+=../../../hal/stm32h5.o
+    PRI_KS_OBJS+=stm32h5.o
 endif
 CC=$(CROSS_COMPILE)gcc
 OBJCOPY?=$(CROSS_COMPILE)objcopy
@@ -42,6 +42,13 @@ otp-keystore-primer.elf: $(PRI_KS_OBJS)
 %.o: %.c
 	$(Q)$(CC) $(CFLAGS) -c -o $@ $<
 
+stm32h7.o: ../../../hal/stm32h7.c
+	$(Q)$(CC) $(CFLAGS) -c -o $@ $<
+
+
+stm32h5.o: ../../../hal/stm32h5.c
+	$(Q)$(CC) $(CFLAGS) -c -o $@ $<
+