pic32c-app: use symbolic name for pins offset

rizlik · danielinux · commit c90c01ac2daf · 2025-06-09T16:29:31.000+02:00
diff --git a/test-app/app_pic32ck.c b/test-app/app_pic32ck.c
@@ -46,16 +46,19 @@
 #define PORTD_OUTCLR (*(volatile uint32_t *)(PORTD_BASE + 0x14))
 #define PORTD_OUTCLR_OUT(X) (1 << (X))
 
+#define LED0_PIN (20)
+#define LED1_PIN (25)
+
 static void led0_on(void)
 {
-    PORTD_DIRSET = PORTD_DIRSET_OUT(20);
-    PORTD_OUTCLR = PORTD_OUTCLR_OUT(20);
+    PORTD_DIRSET = PORTD_DIRSET_OUT(LED0_PIN);
+    PORTD_OUTCLR = PORTD_OUTCLR_OUT(LED0_PIN);
 }
 
 static void led1_on(void)
 {
-    PORTB_DIRSET = PORTB_DIRSET_OUT(25);
-    PORTB_OUTCLR = PORTB_OUTCLR_OUT(25);
+    PORTB_DIRSET = PORTB_DIRSET_OUT(LED1_PIN);
+    PORTB_OUTCLR = PORTB_OUTCLR_OUT(LED1_PIN);
 }
 
 void main(void)
diff --git a/test-app/app_pic32cz.c b/test-app/app_pic32cz.c
@@ -38,16 +38,19 @@
 #define PORTB_OUTCLR (*(volatile uint32_t *)(PORTB_BASE + 0x14))
 #define PORTB_OUTCLR_OUT(X) (1 << (X))
 
+#define LED0_PIN 21
+#define LED1_PIN 22
+
 static void led0_on(void)
 {
-    PORTB_DIRSET = PORTB_DIRSET_OUT(21);
-    PORTB_OUTCLR = PORTB_OUTCLR_OUT(21);
+    PORTB_DIRSET = PORTB_DIRSET_OUT(LED0_PIN);
+    PORTB_OUTCLR = PORTB_OUTCLR_OUT(LED0_PIN);
 }
 
 static void led1_on(void)
 {
-    PORTB_DIRSET = PORTB_DIRSET_OUT(22);
-    PORTB_OUTCLR = PORTB_OUTCLR_OUT(22);
+    PORTB_DIRSET = PORTB_DIRSET_OUT(LED1_PIN);
+    PORTB_OUTCLR = PORTB_OUTCLR_OUT(LED1_PIN);
 }
 
 void main(void)

Original file line number	Diff line number	Diff line change
`@@ -46,16 +46,19 @@`
`46`	`46`	`#define PORTD_OUTCLR ((volatile uint32_t )(PORTD_BASE + 0x14))`
`47`	`47`	`#define PORTD_OUTCLR_OUT(X) (1 << (X))`
`48`	`48`
	`49`	`+#define LED0_PIN (20)`
	`50`	`+#define LED1_PIN (25)`
	`51`	`+`
`49`	`52`	`static void led0_on(void)`
`50`	`53`	`{`
`51`		`- PORTD_DIRSET = PORTD_DIRSET_OUT(20);`
`52`		`- PORTD_OUTCLR = PORTD_OUTCLR_OUT(20);`
	`54`	`+ PORTD_DIRSET = PORTD_DIRSET_OUT(LED0_PIN);`
	`55`	`+ PORTD_OUTCLR = PORTD_OUTCLR_OUT(LED0_PIN);`
`53`	`56`	`}`
`54`	`57`
`55`	`58`	`static void led1_on(void)`
`56`	`59`	`{`
`57`		`- PORTB_DIRSET = PORTB_DIRSET_OUT(25);`
`58`		`- PORTB_OUTCLR = PORTB_OUTCLR_OUT(25);`
	`60`	`+ PORTB_DIRSET = PORTB_DIRSET_OUT(LED1_PIN);`
	`61`	`+ PORTB_OUTCLR = PORTB_OUTCLR_OUT(LED1_PIN);`
`59`	`62`	`}`
`60`	`63`
`61`	`64`	`void main(void)`
Original file line number	Diff line number	Diff line change
`@@ -38,16 +38,19 @@`
`38`	`38`	`#define PORTB_OUTCLR ((volatile uint32_t )(PORTB_BASE + 0x14))`
`39`	`39`	`#define PORTB_OUTCLR_OUT(X) (1 << (X))`
`40`	`40`
	`41`	`+#define LED0_PIN 21`
	`42`	`+#define LED1_PIN 22`
	`43`	`+`
`41`	`44`	`static void led0_on(void)`
`42`	`45`	`{`
`43`		`- PORTB_DIRSET = PORTB_DIRSET_OUT(21);`
`44`		`- PORTB_OUTCLR = PORTB_OUTCLR_OUT(21);`
	`46`	`+ PORTB_DIRSET = PORTB_DIRSET_OUT(LED0_PIN);`
	`47`	`+ PORTB_OUTCLR = PORTB_OUTCLR_OUT(LED0_PIN);`
`45`	`48`	`}`
`46`	`49`
`47`	`50`	`static void led1_on(void)`
`48`	`51`	`{`
`49`		`- PORTB_DIRSET = PORTB_DIRSET_OUT(22);`
`50`		`- PORTB_OUTCLR = PORTB_OUTCLR_OUT(22);`
	`52`	`+ PORTB_DIRSET = PORTB_DIRSET_OUT(LED1_PIN);`
	`53`	`+ PORTB_OUTCLR = PORTB_OUTCLR_OUT(LED1_PIN);`
`51`	`54`	`}`
`52`	`55`
`53`	`56`	`void main(void)`