Skip to content

Commit 870804b

Browse files
committed
Don't do a test compile/link in m4_ax_check_openssl/wolfssl.
Doing a test compile/link is problematic if the user is cross-compiling.
1 parent 0a54fd4 commit 870804b

File tree

3 files changed

+16
-60
lines changed

3 files changed

+16
-60
lines changed

configure.ac

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ AX_CHECK_OPENSSL(
5252

5353
if test "x$have_openssl" = "xyes"; then
5454
LIBS="$LIBS $OPENSSL_LIBS"
55-
CFLAGS="$CFLAGS $OPENSSL_INCLUDES"
55+
CPPFLAGS="$CPPFLAGS $OPENSSL_INCLUDES"
5656
LDFLAGS="$LDFLAGS $OPENSSL_LDFLAGS"
5757
fi
5858

@@ -64,7 +64,7 @@ AX_CHECK_WOLFSSL(
6464

6565
if test "x$have_wolfssl" = "xyes"; then
6666
LIBS="$LIBS $WOLFSSL_LIBS"
67-
CFLAGS="$CFLAGS $WOLFSSL_INCLUDES"
67+
CPPFLAGS="$CPPFLAGS $WOLFSSL_INCLUDES"
6868
LDFLAGS="$LDFLAGS $WOLFSSL_LDFLAGS"
6969
fi
7070

m4/m4_ax_check_openssl.m4

Lines changed: 7 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -104,36 +104,15 @@ AC_DEFUN([AX_CHECK_OPENSSL], [
104104
AC_MSG_RESULT([no])
105105
fi
106106
done
107-
108-
# if the file wasn't found, well, go ahead and try the link anyway -- maybe
109-
# it will just work!
110107
fi
111108
112-
# try the preprocessor and linker with our new flags,
113-
# being careful not to pollute the global LIBS, LDFLAGS, and CPPFLAGS
114-
115-
AC_MSG_CHECKING([whether compiling and linking against OpenSSL works])
116-
echo "Trying link with OPENSSL_LDFLAGS=$OPENSSL_LDFLAGS;" \
117-
"OPENSSL_LIBS=$OPENSSL_LIBS; OPENSSL_INCLUDES=$OPENSSL_INCLUDES" >&AS_MESSAGE_LOG_FD
118-
119-
save_LIBS="$LIBS"
120-
save_LDFLAGS="$LDFLAGS"
121-
save_CPPFLAGS="$CPPFLAGS"
122-
LDFLAGS="$LDFLAGS $OPENSSL_LDFLAGS"
123-
LIBS="$OPENSSL_LIBS $LIBS"
124-
CPPFLAGS="$OPENSSL_INCLUDES $CPPFLAGS"
125-
AC_LINK_IFELSE(
126-
[AC_LANG_PROGRAM([#include <openssl/ssl.h>], [SSL_new(NULL)])],
127-
[
128-
AC_MSG_RESULT([yes])
129-
$1
130-
], [
131-
AC_MSG_RESULT([no])
132-
$2
133-
])
134-
CPPFLAGS="$save_CPPFLAGS"
135-
LDFLAGS="$save_LDFLAGS"
136-
LIBS="$save_LIBS"
109+
if $found; then
110+
AC_MSG_RESULT([yes])
111+
$1
112+
else
113+
AC_MSG_RESULT([no])
114+
$2
115+
fi
137116
138117
AC_SUBST([OPENSSL_INCLUDES])
139118
AC_SUBST([OPENSSL_LIBS])

m4/m4_ax_check_wolfssl.m4

Lines changed: 7 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -86,38 +86,15 @@ AC_DEFUN([AX_CHECK_WOLFSSL], [
8686
AC_MSG_RESULT([no])
8787
fi
8888
done
89-
90-
# if the file wasn't found, well, go ahead and try the link anyway --
91-
# maybe it will just work!
9289
fi
9390
94-
# try the preprocessor and linker with our new flags,
95-
# being careful not to pollute the global LIBS, LDFLAGS, and CPPFLAGS
96-
97-
AC_MSG_CHECKING([whether compiling and linking against wolfSSL works])
98-
echo "Trying link with WOLFSSL_LDFLAGS=$WOLFSSL_LDFLAGS;" \
99-
"WOLFSSL_LIBS=$WOLFSSL_LIBS; WOLFSSL_INCLUDES=$WOLFSSL_INCLUDES" >&AS_MESSAGE_LOG_FD
100-
101-
save_LIBS="$LIBS"
102-
save_LDFLAGS="$LDFLAGS"
103-
save_CPPFLAGS="$CPPFLAGS"
104-
LDFLAGS="$LDFLAGS $WOLFSSL_LDFLAGS"
105-
LIBS="$WOLFSSL_LIBS $LIBS"
106-
CPPFLAGS="$WOLFSSL_INCLUDES $CPPFLAGS"
107-
AC_LINK_IFELSE(
108-
[AC_LANG_PROGRAM([
109-
#include <wolfssl/options.h>
110-
#include <wolfssl/ssl.h>], [wolfSSL_new(NULL)])],
111-
[
112-
AC_MSG_RESULT([yes])
113-
$1
114-
], [
115-
AC_MSG_RESULT([no])
116-
$2
117-
])
118-
CPPFLAGS="$save_CPPFLAGS"
119-
LDFLAGS="$save_LDFLAGS"
120-
LIBS="$save_LIBS"
91+
if $found; then
92+
AC_MSG_RESULT([yes])
93+
$1
94+
else
95+
AC_MSG_RESULT([no])
96+
$2
97+
fi
12198
12299
AC_SUBST([WOLFSSL_INCLUDES])
123100
AC_SUBST([WOLFSSL_LIBS])

0 commit comments

Comments
 (0)