Skip to content

Commit 9062b97

Browse files
committed
Make openssl-unit-tests.sh log file smaller.
Only log test output when the test fails.
1 parent e3363ef commit 9062b97

File tree

1 file changed

+26
-7
lines changed

1 file changed

+26
-7
lines changed

scripts/openssl-unit-tests.sh

Lines changed: 26 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,43 +38,54 @@ do_trap() {
3838
trap do_trap INT TERM
3939

4040
run_testssl() {
41+
# Using ECC keys doesn't work as SSLv3 doesn't have any ciphers
4142
KEY=$CERT_DIR/server-key.pem
4243
CERT=$CERT_DIR/server-cert.pem
4344
CA=$CERT_DIR/ca-cert.pem
4445
printf "\ttestssl RSA..." | tee -a $LOGFILE
45-
sh ./testssl $KEY $CERT $CA &>> $LOGFILE
46+
echo "" >> $LOGFILE # add a newline to make failure logs easier to read
47+
local TMP_LOG=$(mktemp ./log.XXXXX)
48+
sh ./testssl $KEY $CERT $CA &>> $TMP_LOG
4649
if [ $? != 0 ]; then
4750
printf "failed\n"
4851
FAILED=$((FAILED+1))
52+
cat $TMP_LOG >> $LOGFILE
4953
else
5054
printf "passed\n"
5155
fi
52-
53-
# Using ECC keys doesn't work as SSLv3 doesn't have any ciphers
56+
rm $TMP_LOG
5457
}
5558

5659
# Used to run individual ssl-test if wanted, recipes are preferred.
5760
# assuming is running from OpenSSL-1.1.1/test directory
5861
run_individual_111testssl() {
5962
printf "\t$1..." | tee -a $LOGFILE
60-
eval "CTLOG_FILE=ct/log_list.conf TEST_CERTS_DIR=certs ./$* &>> $LOGFILE"
63+
echo "" >> $LOGFILE
64+
local TMP_LOG=$(mktemp ./log.XXXXX)
65+
eval "CTLOG_FILE=ct/log_list.conf TEST_CERTS_DIR=certs ./$* &>> $TMP_LOG"
6166
if [ $? != 0 ]; then
6267
printf "failed\n"
6368
FAILED=$((FAILED+1))
69+
cat $TMP_LOG >> $LOGFILE
6470
else
6571
printf "passed\n"
6672
fi
73+
rm $TMP_LOG
6774
}
6875

6976
run_111recipe() {
7077
printf "\t$1..." | tee -a $LOGFILE
71-
eval "SRCTOP=../. BLDTOP=../. RESULT_D=test-runs PERL="/usr/bin/perl" EXE_EXT= OPENSSL_ENGINES=`cd ../../.libs 2>/dev/null && pwd` OPENSSL_DEBUG_MEMORY=on perl run_tests.pl $1 &>> $LOGFILE"
78+
echo "" >> $LOGFILE
79+
local TMP_LOG=$(mktemp ./log.XXXXX)
80+
eval "SRCTOP=../. BLDTOP=../. RESULT_D=test-runs PERL="/usr/bin/perl" EXE_EXT= OPENSSL_ENGINES=`cd ../../.libs 2>/dev/null && pwd` OPENSSL_DEBUG_MEMORY=on perl run_tests.pl $1 &>> $TMP_LOG"
7281
if [ $? != 0 ]; then
7382
printf "failed\n"
7483
FAILED=$((FAILED+1))
84+
cat $TMP_LOG >> $LOGFILE
7585
else
7686
printf "passed\n"
7787
fi
88+
rm $TMP_LOG
7889
}
7990

8091
# used to regenerate ssl-test/ files that have the .in changed
@@ -84,25 +95,33 @@ run_111testssl_generate() {
8495

8596
run_openssl() {
8697
printf "\t$1 $2..." | tee -a $LOGFILE
98+
echo "" >> $LOGFILE
99+
local TMP_LOG=$(mktemp ./log.XXXXX)
87100
(LD_LIBRARY_PATH="$WOLFENGINE_LIBS:$LD_LIBRARY_PATH" \
88-
eval "../apps/openssl $1 -engine wolfengine $2" &>> $LOGFILE)
101+
eval "../apps/openssl $1 -engine wolfengine $2" &>> $TMP_LOG)
89102
if [ $? != 0 ]; then
90103
printf "failed\n"
91104
FAILED=$((FAILED+1))
105+
cat $TMP_LOG >> $LOGFILE
92106
else
93107
printf "passed\n"
94108
fi
109+
rm $TMP_LOG
95110
}
96111

97112
run_test() {
98113
printf "\t$1..." | tee -a $LOGFILE
99-
./$* &>> $LOGFILE
114+
echo "" >> $LOGFILE
115+
local TMP_LOG=$(mktemp ./log.XXXXX)
116+
./$* &>> $TMP_LOG
100117
if [ $? != 0 ]; then
101118
printf "failed\n"
102119
FAILED=$((FAILED+1))
120+
cat $TMP_LOG >> $LOGFILE
103121
else
104122
printf "passed\n"
105123
fi
124+
rm $TMP_LOG
106125
}
107126

108127
create_tmp_conf() {

0 commit comments

Comments
 (0)