clang warning fix and valgrind fixes

Author: JacobBarthelmeh

src/we_aes_block.c

@@ -148,7 +148,7 @@ static int we_aes_cbc_encrypt(we_AesBlock* aes, unsigned char *out,
     WOLFENGINE_ENTER(WE_LOG_CIPHER, "we_aes_cbc_encrypt");
 
     /* padding is handled by OpenSSL before passed to we_aes_cbc_encrypt */
-    rc = wc_AesCbcEncrypt(&aes->aes, out, in, len);
+    rc = wc_AesCbcEncrypt(&aes->aes, out, in, (unsigned int)len);
     if (rc != 0) {
         WOLFENGINE_ERROR_FUNC(WE_LOG_CIPHER, "wc_AesCbcEncrypt", rc);
         ret = 0;
@@ -179,13 +179,13 @@ static int we_aes_cbc_decrypt(we_AesBlock* aes, unsigned char *out,
     WOLFENGINE_ENTER(WE_LOG_CIPHER, "we_aes_cbc_decrypt");
 
     /* padding is handled by OpenSSL before passed to we_aes_cbc_decrypt */
-    rc = wc_AesCbcDecrypt(&aes->aes, out, in, len);
+    rc = wc_AesCbcDecrypt(&aes->aes, out, in, (unsigned int)len);
     if (rc != 0) {
         ret = -1;
     }
 
     if (ret >= 0) {
-        ret = len;
+        ret = (int)len;
     }
 
     WOLFENGINE_LEAVE(WE_LOG_CIPHER, "we_aes_cbc_encrypt", ret);

test/test_hkdf.c

@@ -98,6 +98,9 @@ static int test_hkdf_md(ENGINE *e, const EVP_MD *md, int mode)
     unsigned char oKey[128];
     unsigned char wKey[128];
 
+    memset(oKey, 0, sizeof(oKey));
+    memset(wKey, 0, sizeof(wKey));
+
     PRINT_MSG("Calc with OpenSSL");
     err = test_hkdf_calc(NULL, oKey, sizeof(oKey), md, mode);
     if (err == 1) {

test/test_pkey.c

@@ -259,7 +259,7 @@ int test_pkey_dec(EVP_PKEY *pkey, ENGINE *e, unsigned char *msg, size_t msgLen,
     size_t len = cipherLen;
     unsigned char *buf;
 
-    buf = (unsigned char*)OPENSSL_malloc(cipherLen);
+    buf = (unsigned char*)OPENSSL_zalloc(cipherLen);
     if (buf == NULL) {
         err = 1;
     }

test/test_rsa.c

@@ -398,15 +398,15 @@ static int test_rsa_direct(ENGINE *e, const unsigned char *der, size_t derLen,
         err = RAND_bytes(buf, sizeof(buf)) == 0;
     }
     if (err == 0) {
-        encryptedBuf = (unsigned char*)OPENSSL_malloc(rsaSize);
+        encryptedBuf = (unsigned char*)OPENSSL_zalloc(rsaSize);
         err = encryptedBuf == NULL;
     }
     if (err == 0) {
-        decryptedBuf = (unsigned char*)OPENSSL_malloc(rsaSize);
+        decryptedBuf = (unsigned char*)OPENSSL_zalloc(rsaSize);
         err = decryptedBuf == NULL;
     }
     if (err == 0) {
-        noPaddingBuf = (unsigned char*)OPENSSL_malloc(rsaSize);
+        noPaddingBuf = (unsigned char*)OPENSSL_zalloc(rsaSize);
         err = noPaddingBuf == NULL;
     }
     if (err == 0) {
@@ -956,14 +956,14 @@ static int test_rsa_enc_dec(ENGINE *e, const unsigned char *der, size_t derLen,
     }
     if (err == 0) {
         rsaEncLen = RSA_size(rsaKey);
-        rsaEnc = (unsigned char*)OPENSSL_malloc(rsaEncLen);
+        rsaEnc = (unsigned char*)OPENSSL_zalloc(rsaEncLen);
         err = rsaEnc == NULL;
     }
     if (err == 0) {
         if (padMode == RSA_NO_PADDING) {
             bufLen = rsaEncLen;
         }
-        buf = (unsigned char *)OPENSSL_malloc(bufLen);
+        buf = (unsigned char *)OPENSSL_zalloc(bufLen);
         err = buf == NULL;
     }
     if (err == 0) {