cppcheck: fix redundant check on ret==0

Author: bigbrett

src/wh_she_crypto.c

@@ -135,7 +135,7 @@ int wh_She_GenerateLoadableKey(uint8_t keyId,
     ret = wh_AesMp16(kdfInput,
         WH_SHE_KEY_SZ + sizeof(_SHE_KEY_UPDATE_ENC_C), tmpKey);
 
-    /* Build M1 and cleartext M2 */
+    /* Build M1 and cleartext M2, then encrypt M2 with K1 */
     if (ret == 0) {
         /* Build M1: set UID, key id and authId */
         memcpy(messageOne, uid, WH_SHE_UID_SZ);
@@ -149,9 +149,8 @@ int wh_She_GenerateLoadableKey(uint8_t keyId,
                 (count  << WH_SHE_M2_COUNT_SHIFT) |
                 (flags  << WH_SHE_M2_FLAGS_SHIFT) );
         memcpy(messageTwo + WH_SHE_M2_KEY_OFFSET, key, WH_SHE_KEY_SZ);
-    }
-    /* encrypt M2 with K1 */
-    if (ret == 0) {
+
+        /* encrypt M2 with K1 */
         ret = wc_AesInit(aes, NULL, INVALID_DEVID);
         if (ret == 0) {
             ret = wc_AesSetKey(aes, tmpKey, WH_SHE_KEY_SZ, NULL,