Merge pull request #188 from AlexLanzano/clang-tidy-fix

bigbrett · web-flow · commit 5debb7e34606 · 2025-09-24T13:44:19.000-06:00
Fix static-analyizer warnings
diff --git a/src/wh_server_keystore.c b/src/wh_server_keystore.c
@@ -1181,8 +1181,8 @@ int wh_Server_HandleKeyRequest(whServerContext* server, uint16_t magic,
             }
         } break;
         case WH_KEY_WRAP: {
-            whMessageKeystore_WrapRequest  wrapReq;
-            whMessageKeystore_WrapResponse wrapResp;
+            whMessageKeystore_WrapRequest  wrapReq  = {0};
+            whMessageKeystore_WrapResponse wrapResp = {0};
             uint8_t*                       reqData;
             uint8_t*                       respData;
             uint32_t reqDataSz  = WOLFHSM_CFG_COMM_DATA_LEN - sizeof(wrapReq);
@@ -1217,8 +1217,8 @@ int wh_Server_HandleKeyRequest(whServerContext* server, uint16_t magic,
         } break;
 
         case WH_KEY_UNWRAPEXPORT: {
-            whMessageKeystore_UnwrapAndExportRequest  unwrapReq;
-            whMessageKeystore_UnwrapAndExportResponse unwrapResp;
+            whMessageKeystore_UnwrapAndExportRequest  unwrapReq  = {0};
+            whMessageKeystore_UnwrapAndExportResponse unwrapResp = {0};
             uint8_t*                                  reqData;
             uint8_t*                                  respData;
             uint32_t reqDataSz = WOLFHSM_CFG_COMM_DATA_LEN - sizeof(unwrapReq);
@@ -1255,8 +1255,8 @@ int wh_Server_HandleKeyRequest(whServerContext* server, uint16_t magic,
         } break;
 
         case WH_KEY_UNWRAPCACHE: {
-            whMessageKeystore_UnwrapAndCacheRequest  cacheReq;
-            whMessageKeystore_UnwrapAndCacheResponse cacheResp;
+            whMessageKeystore_UnwrapAndCacheRequest  cacheReq  = {0};
+            whMessageKeystore_UnwrapAndCacheResponse cacheResp = {0};
             uint8_t*                                 reqData;
             uint8_t*                                 respData;
             uint32_t reqDataSz  = WOLFHSM_CFG_COMM_DATA_LEN - sizeof(cacheReq);
diff --git a/test/wh_test_keywrap.c b/test/wh_test_keywrap.c
@@ -200,5 +200,4 @@ int whTest_KeyWrapClientConfig(whClientConfig* config)
     return ret;
 }
 #endif /* WOLFHSM_CFG_ENABLE_CLIENT */
-
 #endif /* !WOLFHSM_CFG_NO_CRYPTO */
diff --git a/tools/static-analysis/clang-tidy-builder.sh b/tools/static-analysis/clang-tidy-builder.sh

Original file line number	Diff line number	Diff line change
`@@ -200,5 +200,4 @@ int whTest_KeyWrapClientConfig(whClientConfig* config)`
`200`	`200`	`return ret;`
`201`	`201`	`}`
`202`	`202`	`#endif /* WOLFHSM_CFG_ENABLE_CLIENT */`
`203`		`-`
`204`	`203`	`#endif /* !WOLFHSM_CFG_NO_CRYPTO */`