address review feedback

Author: bigbrett

src/wh_log_printf.c

@@ -82,11 +82,15 @@ int whLogPrintf_AddEntry(void* c, const whLogEntry* entry)
 #endif
 
     /* Format: [TIMESTAMP] [LEVEL] [FILE:LINE FUNC] MESSAGE */
-    WOLFHSM_CFG_PRINTF(
+    (void)WOLFHSM_CFG_PRINTF(
         "[%llu] [%s] [%s:%u %s] %.*s\n", (unsigned long long)entry->timestamp,
-        wh_Log_LevelToString(entry->level), entry->file ? entry->file : "",
-        entry->line, entry->function ? entry->function : "",
-        (int)entry->msg_len, entry->msg);
+        wh_Log_LevelToString(entry->level),
+        (entry->file != NULL) ? entry->file : "", entry->line,
+        (entry->function != NULL) ? entry->function : "",
+        (entry->msg_len <= WOLFHSM_CFG_LOG_MSG_MAX)
+            ? (int)(entry->msg_len)
+            : (int)WOLFHSM_CFG_LOG_MSG_MAX,
+        entry->msg);
 
     return WH_ERROR_OK;
 }

src/wh_server.c

@@ -410,6 +410,7 @@ int wh_Server_HandleRequestMessage(whServerContext* server)
         default:
             /* Unknown group. Return empty packet */
             rc   = WH_ERROR_NOTIMPL;
+            data = NULL;
             size = 0;
         }
 
@@ -447,9 +448,9 @@ int wh_Server_HandleRequestMessage(whServerContext* server)
             "SendResponse failed for (group=%d, action=%d, seq=%d): %d", group,
             action, seq, rc);
 
-        /* Always return success when we processed a request, so no handler
-         * error can terminate the server's request processing loop. */
-        rc = WH_ERROR_OK;
+        /* Handler errors are logged above via handlerRc but don't affect
+         * return code. Errors from SendResponse are propagated back to the
+         * caller in rc */
     }
     else if (rc != WH_ERROR_NOTREADY) {
         /* Log error code from processing request, if present */

wolfhsm/wh_log_printf.h

@@ -33,8 +33,10 @@
 
 /* Printf configuration structure */
 typedef struct whLogPrintfConfig_t {
-    int logIfNotDebug; /* When true, always log regardless of WOLFHSM_CFG_DEBUG
-                        */
+    int logIfNotDebug; /* When non-zero, log entries are printed even if
+                        * WOLFHSM_CFG_DEBUG is not defined. When zero, entries
+                        * are only printed if WOLFHSM_CFG_DEBUG is defined. This
+                        * flag applies to all log levels */
 } whLogPrintfConfig;
 
 /* Printf context structure */