Initalized req resp and int overflow fixes for server_counter

Author: jackctj117

src/wh_server_counter.c

@@ -56,16 +56,17 @@ int wh_Server_HandleCounter(whServerContext* server, uint16_t magic,
 
     switch (action) {
         case WH_COUNTER_INIT: {
-            whMessageCounter_InitRequest  req;
-            whMessageCounter_InitResponse resp;
+            whMessageCounter_InitRequest  req = {0};
+            whMessageCounter_InitResponse resp = {0};
 
             /* translate request */
             (void)wh_MessageCounter_TranslateInitRequest(
                 magic, (whMessageCounter_InitRequest*)req_packet, &req);
 
             /* write 0 to nvm with the supplied id and user_id */
             meta->id = WH_MAKE_KEYID(WH_KEYTYPE_COUNTER,
-                                     server->comm->client_id, req.counterId);
+                                     (uint16_t)server->comm->client_id,
+                                     (uint16_t)req.counterId);
             /* use the label buffer to hold the counter value */
             *counter = req.counter;
             ret      = wh_Nvm_AddObjectWithReclaim(server->nvm, meta, 0, NULL);
@@ -83,8 +84,8 @@ int wh_Server_HandleCounter(whServerContext* server, uint16_t magic,
         } break;
 
         case WH_COUNTER_INCREMENT: {
-            whMessageCounter_IncrementRequest  req;
-            whMessageCounter_IncrementResponse resp;
+            whMessageCounter_IncrementRequest  req = {0};
+            whMessageCounter_IncrementResponse resp = {0};
 
             /* translate request */
             (void)wh_MessageCounter_TranslateIncrementRequest(
@@ -93,8 +94,8 @@ int wh_Server_HandleCounter(whServerContext* server, uint16_t magic,
             /* read the counter, stored in the metadata label */
             ret     = wh_Nvm_GetMetadata(server->nvm,
                                          WH_MAKE_KEYID(WH_KEYTYPE_COUNTER,
-                                                       server->comm->client_id,
-                                                       req.counterId),
+                                                       (uint16_t)server->comm->client_id,
+                                                       (uint16_t)req.counterId),
                                          meta);
             resp.rc = ret;
 
@@ -128,8 +129,8 @@ int wh_Server_HandleCounter(whServerContext* server, uint16_t magic,
         } break;
 
         case WH_COUNTER_READ: {
-            whMessageCounter_ReadRequest  req;
-            whMessageCounter_ReadResponse resp;
+            whMessageCounter_ReadRequest  req = {0};
+            whMessageCounter_ReadResponse resp = {0};
 
             /* translate request */
             (void)wh_MessageCounter_TranslateReadRequest(
@@ -138,8 +139,8 @@ int wh_Server_HandleCounter(whServerContext* server, uint16_t magic,
             /* read the counter, stored in the metadata label */
             ret     = wh_Nvm_GetMetadata(server->nvm,
                                          WH_MAKE_KEYID(WH_KEYTYPE_COUNTER,
-                                                       server->comm->client_id,
-                                                       req.counterId),
+                                                       (uint16_t)server->comm->client_id,
+                                                       (uint16_t)req.counterId),
                                          meta);
             resp.rc = ret;
 
@@ -158,15 +159,16 @@ int wh_Server_HandleCounter(whServerContext* server, uint16_t magic,
         } break;
 
         case WH_COUNTER_DESTROY: {
-            whMessageCounter_DestroyRequest  req;
-            whMessageCounter_DestroyResponse resp;
+            whMessageCounter_DestroyRequest  req = {0};
+            whMessageCounter_DestroyResponse resp = {0};
 
             /* translate request */
             (void)wh_MessageCounter_TranslateDestroyRequest(
                 magic, (whMessageCounter_DestroyRequest*)req_packet, &req);
 
             counterId = WH_MAKE_KEYID(WH_KEYTYPE_COUNTER,
-                                      server->comm->client_id, req.counterId);
+                                      (uint16_t)server->comm->client_id,
+                                      (uint16_t)req.counterId);
 
             ret     = wh_Nvm_DestroyObjects(server->nvm, 1, &counterId);
             resp.rc = ret;