Peer review cleanups. Not touching any of the license header issues.

Author: dgarske

examples/ets_test/ets_test.c

@@ -57,7 +57,7 @@ typedef struct WorkThreadCtx {
 /* for error response in errorMode, 0 on success */
 static int DoErrorMode(void)
 {
-    /* TODO: Add error case */
+    /* TODO: Add code to test expected error cases */
 
     return 0;
 }

examples/https/README.md

@@ -2,7 +2,7 @@
 
 These examples demonstrate a basic HTTPS server and client for testing the ETS middle-box decryption with the wolf Key Manager tool.
 
-## TlS Server
+## TLS Server
 
 Usage: `./examples/https/server`
 

examples/https/server.c

@@ -131,8 +131,8 @@ int https_server_test(int argc, char** argv)
         if (useKeyMgr) {
             ret = ets_client_get_all(etsServer, ets_key_cb, ctx);
             if (ret != 0) {
-                printf("\nFailure connecting to key manager\n");
-                printf("Make sure ./src/wolfkeymgr is running\n");
+                fprintf(stderr, "\nFailure connecting to key manager\n");
+                fprintf(stderr, "Make sure ./src/wolfkeymgr is running\n");
                 mStop = 1;
                 goto end_sess;
             }

src/mod_tls.c

@@ -234,8 +234,9 @@ static int wolfTlsInitSslDefaults(WOLFSSL_CTX* ctx, WOLFSSL** ssl)
         wolfSSL_SetIOWriteCtx(tssl, cbCtx);
 
     #if 0
-        /* example for forcing a key share type (see ssl.h Named Groups enum) */
-        wolfSSL_UseKeyShare(tssl, WOLFSSL_ECC_X448);
+        /* Example for forcing a key share type (see ssl.h Named Groups enum).
+         * WOLFSSL_FFDHE_2048, WOLFSSL_ECC_X25519, WOLFSSL_ECC_X448, etc... */
+        wolfSSL_UseKeyShare(tssl, WOLFSSL_ECC_SECP256R1);
     #endif
 
         *ssl = tssl;