Add comment on where failure happens

aidangarske · aidangarske · commit 26176302cd74 · 2025-12-16T09:30:31.000-08:00
diff --git a/src/wp_ecc_kmgmt.c b/src/wp_ecc_kmgmt.c
@@ -1168,6 +1168,9 @@ static int wp_ecc_import_keypair(wp_Ecc* ecc, const OSSL_PARAM params[],
                     ecc->key.type = ECC_PRIVATEKEY;
                     ecc->hasPub = 1;
                 }
+                /* If derivation fails, continue.
+                 * The key is still valid for private key operations.
+                 * We will fail later if public key is accessed. */
             }
         }
 #endif /* OPENSSL_VERSION_NUMBER > 0x30600000L 3.6.0+ */

Original file line number	Diff line number	Diff line change
`@@ -1168,6 +1168,9 @@ static int wp_ecc_import_keypair(wp_Ecc* ecc, const OSSL_PARAM params[],`
`1168`	`1168`	`ecc->key.type = ECC_PRIVATEKEY;`
`1169`	`1169`	`ecc->hasPub = 1;`
`1170`	`1170`	`}`
	`1171`	`+ /* If derivation fails, continue.`
	`1172`	`+ * The key is still valid for private key operations.`
	`1173`	`+ * We will fail later if public key is accessed. */`
`1171`	`1174`	`}`
`1172`	`1175`	`}`
`1173`	`1176`	`#endif /* OPENSSL_VERSION_NUMBER > 0x30600000L 3.6.0+ */`