Merge pull request #199 from padelsbach/wp_aesgcm_uninit_variable

ColtonWilley · web-flow · commit 9d09b0549ef5 · 2025-07-01T09:40:01.000-07:00
Fix uninitialized variable in aesgcm
diff --git a/src/wp_aes_aead.c b/src/wp_aes_aead.c
@@ -1559,12 +1559,13 @@ static int wp_aesgcm_cipher(wp_AeadCtx *ctx, unsigned char *out,
     size_t *outLen, size_t outSize, const unsigned char *in, size_t inLen)
 {
     int ok = 1;
-    size_t finalLen;
+    size_t finalLen = 0;
 
     if (!wolfssl_prov_is_running()) {
         ok = 0;
     }
     if (ok) {
+        *outLen = 0;
         if (in != NULL) {
             ok = wp_aesgcm_stream_update(ctx, out, outLen, outSize, in, inLen);
         }

Original file line number	Diff line number	Diff line change
`@@ -1559,12 +1559,13 @@ static int wp_aesgcm_cipher(wp_AeadCtx ctx, unsigned char out,`
`1559`	`1559`	`size_t outLen, size_t outSize, const unsigned char in, size_t inLen)`
`1560`	`1560`	`{`
`1561`	`1561`	`int ok = 1;`
`1562`		`- size_t finalLen;`
	`1562`	`+ size_t finalLen = 0;`
`1563`	`1563`
`1564`	`1564`	`if (!wolfssl_prov_is_running()) {`
`1565`	`1565`	`ok = 0;`
`1566`	`1566`	`}`
`1567`	`1567`	`if (ok) {`
	`1568`	`+ *outLen = 0;`
`1568`	`1569`	`if (in != NULL) {`
`1569`	`1570`	`ok = wp_aesgcm_stream_update(ctx, out, outLen, outSize, in, inLen);`
`1570`	`1571`	`}`