Addressing PR comments

Andras Fekete · Andras Fekete · commit beb3df4c1c77 · 2024-06-27T09:10:53.000-04:00
diff --git a/src/wp_rsa_sig.c b/src/wp_rsa_sig.c
@@ -417,12 +417,13 @@ static int wp_rsa_signverify_init(wp_RsaSigCtx* ctx, wp_Rsa* rsa,
     if ((ctx == NULL) || (rsa == NULL)) {
         ok = 0;
     }
-    if ((ok) && (ctx->rsa != rsa)) {
+    if (ok && (ctx->rsa != rsa)) {
         wp_rsa_free(ctx->rsa);
         ctx->rsa = NULL;
         if (!wp_rsa_up_ref(rsa)) {
             ok = 0;
-        } else {
+        }
+        else {
             ctx->rsa = rsa;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -417,12 +417,13 @@ static int wp_rsa_signverify_init(wp_RsaSigCtx* ctx, wp_Rsa* rsa,`
`417`	`417`	`if ((ctx == NULL) \|\| (rsa == NULL)) {`
`418`	`418`	`ok = 0;`
`419`	`419`	`}`
`420`		`- if ((ok) && (ctx->rsa != rsa)) {`
	`420`	`+ if (ok && (ctx->rsa != rsa)) {`
`421`	`421`	`wp_rsa_free(ctx->rsa);`
`422`	`422`	`ctx->rsa = NULL;`
`423`	`423`	`if (!wp_rsa_up_ref(rsa)) {`
`424`	`424`	`ok = 0;`
`425`		`- } else {`
	`425`	`+ }`
	`426`	`+ else {`
`426`	`427`	`ctx->rsa = rsa;`
`427`	`428`	`}`
`428`	`429`	`}`